Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Catch Up The Sublime Linter API: #13

Merged
merged 3 commits into from
Mar 30, 2020

Conversation

Edditoria
Copy link
Collaborator

@Edditoria Edditoria commented Mar 29, 2020

  • Use WARNING instead of util and hightlight.
  • Update cmd key to meet the requirement of Sublime Linter
  • The Linter panel can properly show "warnings" now

Solves #10 . Specially thanks @pykong for tips. 🍕

Didn't notice the previous commit will trigger a merge. Not sure how version update will affect deployments. Hopefully I can catch up! Sorry for inconvenience!

@braver
Copy link
Member

braver commented Mar 29, 2020

Oh, sorry, didn’t know you we’re going to fix the entire thing! This is great. I’m not going to be able to test this, but assume you did.
This is a full on new major release! Are you ready to release it? Also, would you like access to the repo so that you can make other changes as you see fit?

@Edditoria
Copy link
Collaborator Author

Edditoria commented Mar 30, 2020

It works in ST3 on Windows 10 and macOS. npm i -g pug-lint, install "pug" and "Sublime Linter" in ST3 and it works flawlessly. I think it meets the standard of Sublime-Linter. You can release it anytime.

And sure, add me if you like. I may need more information on some tips, e.g. compilability on ST2.

@braver
Copy link
Member

braver commented Mar 30, 2020

Oh, ST2 is not supported by SublimeLinter, so don’t worry about that.

Thanks!

@braver
Copy link
Member

braver commented Mar 30, 2020

You’re now a maintainer of this repo, so feel free to merge this PR and create a 2.0.0 release!

@Edditoria Edditoria merged commit 20415b1 into SublimeLinter:master Mar 30, 2020
@Edditoria Edditoria mentioned this pull request Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants