-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output in build panel + Sublime build execution #54
Conversation
Thank you for creating PR! One point:
This is OK. There is also need to disable output in editor (#52), I think about changing the option about this. Let's adopt yours. |
Hm, good point! I could remove the I could also change the selector to include specific languages, like Julia and R? I can see from the list of Jupyter kernels that there are a lot of languages that can run in Jupyter, but maybe we could pick the language that are most commonly used in Jupyter - like Julia, R and Python? |
Hmm. I think that it's sufficient if the build system does not run on the view without connection to Jupyter kernels. |
Sorry for leaving this PR for a while. I want to merge this but still thinks it is good to not limit the scope by syntax, otherwise enable the build command iff the active view is connected to a Jupyter kernel through Hermes. We can do it by implementing I can do some work if you agree to this direction. |
No problem, I don't have as much free time to spend on this as I'd like, so there is no hurry. I had not thought of using the I have tried experimenting with removing the |
OK, then I'm going to take over your working branch and try to do what I said above. Thanks. |
@eirki Thanks for your effort into this PR. Closing. |
As mentioned in #53, these changes add support for printing the output in Sublime's output panel. They also include .sublime-build files, so that SublimeHermes can be executed using
ctrl+b
(after having selected it as build system usingctrl+shift+b
).One change I am not certain about is the .sublime-settings file. I've changed the
inline_output
bool to variable calledoutput_style
, which can be set todefault
,inline
orpanel
. Since this would invalidate theinline_output
setting in existing user setting files, it might not be a good idea? I'm happy to try to implement any suggestions you have.