chore: from nil to empty string

Signed-off-by: ThibaultFy <[email protected]>
Substra · Dec 19, 2023 · f2ffbaa · f2ffbaa
1 parent 92707c4
commit f2ffbaa
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/service/function.go b/lib/service/function.go
@@ -150,7 +150,7 @@ func (s *FunctionService) UpdateFunction(a *asset.UpdateFunctionParam, requester
 		return orcerrors.NewPermissionDenied("requester does not own the function")
 	}
 
-	if function.Image == nil && function.Status == asset.FunctionStatus_FUNCTION_STATUS_READY {
+	if function.Image.Checksum == "" && function.Status == asset.FunctionStatus_FUNCTION_STATUS_READY {
 		return orcerrors.FromValidationError(asset.FunctionKind, errors.New("Image should not be null when function status is ready"))
 	}
 

diff --git a/server/standalone/dbal/function.go b/server/standalone/dbal/function.go
@@ -55,7 +55,7 @@ func (d *DBAL) AddFunction(function *asset.Function) error {
 	}
 
 	var imageStorageAdress sql.NullString
-	if function.Image != nil {
+	if function.Image.Checksum != "" {
 		err = d.addAddressable(function.Image)
 		if err != nil {
 			return err