feat!: add function events #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FL-1160 Add function event
ContextStatuses:
SpecificationAcceptance criteria |
This was referenced Oct 12, 2023
SdgJlbl
force-pushed
the
poc-decoupled-builder
branch
from
afd9135 to
4cb71a0
Compare
SdgJlbl
changed the title
SdgJlbl
force-pushed
the
poc-decoupled-builder
branch
from
4cb71a0 to
04cb078
Compare
SdgJlbl
approved these changes
Oct 20, 2023
SdgJlbl
force-pushed
the
poc-decoupled-builder
branch
from
04cb078 to
5ccaa18
Compare
thbcmlowk
force-pushed
the
poc-decoupled-builder
branch
from
5ccaa18 to
e93a611
Compare
- Substra/substra-backend#714 Add function events, used now we decoupled the building of the function with the execution of the compute task. For that it add a status field on the `Function`. It also includes another PR (merged here), to have functions build logs working again. Fixes FL-1160 As this is going to be merged on a branch that is going to be merged to a POC branch, we use MNIST as a baseline of a working model. We will deal with failing tests on the POC before merging on main. - [x] [changelog](../CHANGELOG.md) was updated with notable changes - [ ] documentation was updated --------- Signed-off-by: Guilhem Barthes <[email protected]> Signed-off-by: Guilhem Barthés <[email protected]> Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: guilhem-barthes <[email protected]>
Signed-off-by: thbcmlowk <[email protected]>
thbcmlowk
force-pushed
the
poc-decoupled-builder
branch
from
e93a611 to
0245a55
Compare
Signed-off-by: Guilhem Barthés <[email protected]>
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Add function events, used now we decoupled the building of the function with the execution of the compute task. For that it add a status field on the
Function. It also includes another PR (merged here), to have functions build logs working again.Fixes FL-1160
As this is going to be merged on a branch that is going to be merged to a POC branch, we use MNIST as a baseline of a working model. We will deal with failing tests on the POC before merging on main.
Companion PR
Misc
Description
How has this been tested?
Checklist