Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): refactor existing helm gha workflow #321

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

kaanyagci
Copy link
Contributor

@kaanyagci kaanyagci commented Oct 19, 2023

Description

Closes FL-1240

Added

  • Checking if Chart.lock file is also updated

Changed

  • Existing helm GitHub Action workflow refactored to use substra/substra-gha-workflows/.github/workflows/helm.yml.

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@kaanyagci kaanyagci self-assigned this Oct 19, 2023
@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch from bc95411 to 13a43f7 Compare November 5, 2023 22:16
@kaanyagci kaanyagci changed the title refactor(ci): refactor common GHA workflows refactor(ci): refactor existing helm gha workflow Nov 5, 2023
@kaanyagci kaanyagci added the github_actions Pull requests that update GitHub Actions code label Nov 5, 2023
@kaanyagci kaanyagci marked this pull request as ready for review November 5, 2023 22:48
@kaanyagci kaanyagci requested a review from a team as a code owner November 5, 2023 22:48
@kaanyagci kaanyagci requested a review from oleobal November 5, 2023 22:48
@kaanyagci kaanyagci enabled auto-merge (squash) November 5, 2023 22:48
Copy link

linear bot commented Jan 15, 2024

Existing GHA workflow is changed with the generic one from substra-gha-workflows

Signed-off-by: Kaan Yagci <[email protected]>
@kaanyagci kaanyagci force-pushed the refactor/common-gha-workflows branch from 13a43f7 to 318af1b Compare February 6, 2024 14:05
Copy link
Contributor

@SdgJlbl SdgJlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kaanyagci kaanyagci merged commit d223395 into main Feb 16, 2024
6 checks passed
@kaanyagci kaanyagci deleted the refactor/common-gha-workflows branch February 16, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants