Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove distributed mode #341

Merged
merged 13 commits into from
Dec 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Removed

- BREAKING: remove all code related to the `distributed` mode, and mentions in schemas and documentation ([#341](https://github.com/Substra/orchestrator/pull/341))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it breaking if we already removed the functionality? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we ? I was thinkin that as the code was still there, the feature was too (even if we already cut some access to it). But if we consider the feature was already deactivated, then I fully agree with you :)

- BREAKING: `distributed` Skaffold profile and mentions in doc ([#319](https://github.com/Substra/orchestrator/pull/319))
- BREAKING: `chaincode-init` and `chaincode` Dockerfiles ([#319](https://github.com/Substra/orchestrator/pull/319))

4 changes: 0 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
OUTPUT_DIR = ./bin
CHAINCODE_BIN = $(OUTPUT_DIR)/chaincode
ORCHESTRATOR_BIN = $(OUTPUT_DIR)/orchestrator
PROJECT_ROOT = .
MIGRATIONS_DIR = $(PROJECT_ROOT)/server/standalone/migration
@@ -45,9 +44,6 @@ format: codegen # Format codebase
$(ORCHESTRATOR_BIN): $(pbgo) $(go_src) $(OUTPUT_DIR) $(lib_generated)
$(build_env) go build -o $(ORCHESTRATOR_BIN) -ldflags="-X 'github.com/substra/orchestrator/server/common.Version=$(VERSION)'" ./server

$(CHAINCODE_BIN): $(pbgo) $(go_src) $(OUTPUT_DIR) $(lib_generated)
$(build_env) go build -o $(CHAINCODE_BIN) -ldflags="-X 'github.com/substra/orchestrator/chaincode/info.Version=$(VERSION)'" ./chaincode

$(OUTPUT_DIR):
mkdir $(OUTPUT_DIR)

3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -24,7 +24,6 @@ This component's purpose is to orchestrate task processing in multiple channels
- it is the single source of truth of _Substra_ organizations;
- it exposes necessary data to _Substra_ instances to process their tasks and register their assets;
- its API is aimed to serve backends, not end-users;
- it works the same way in both standalone and distributed mode;
- it enforces that all registered data are valid;
- it ensures data consistency under multiple concurrent requests;

@@ -128,7 +127,7 @@ Then you can launch call like this:
```
package orchestrator
service OrganizationService
header mspid=MyOrg1MSP channel=mychannel chaincode=mycc
header mspid=MyOrg1MSP channel=mychannel
call GetAllOrganizations
```

60 changes: 0 additions & 60 deletions chaincode/communication/wrapper.go

This file was deleted.

30 changes: 0 additions & 30 deletions chaincode/communication/wrapper_test.go

This file was deleted.

217 changes: 0 additions & 217 deletions chaincode/computeplan/contract.go

This file was deleted.

142 changes: 0 additions & 142 deletions chaincode/computeplan/contract_test.go

This file was deleted.

231 changes: 0 additions & 231 deletions chaincode/computetask/contract.go

This file was deleted.

82 changes: 0 additions & 82 deletions chaincode/computetask/contract_test.go

This file was deleted.

51 changes: 0 additions & 51 deletions chaincode/contracts/collection.go

This file was deleted.

14 changes: 0 additions & 14 deletions chaincode/contracts/collection_test.go

This file was deleted.

33 changes: 0 additions & 33 deletions chaincode/contracts/contracts.go

This file was deleted.

166 changes: 0 additions & 166 deletions chaincode/datamanager/contract.go

This file was deleted.

121 changes: 0 additions & 121 deletions chaincode/datamanager/contract_test.go

This file was deleted.

167 changes: 0 additions & 167 deletions chaincode/datasample/contract.go

This file was deleted.

118 changes: 0 additions & 118 deletions chaincode/datasample/contract_test.go

This file was deleted.

63 changes: 0 additions & 63 deletions chaincode/dataset/contract.go

This file was deleted.

62 changes: 0 additions & 62 deletions chaincode/dataset/contract_test.go

This file was deleted.

74 changes: 0 additions & 74 deletions chaincode/event/contract.go

This file was deleted.

97 changes: 0 additions & 97 deletions chaincode/failurereport/contract.go

This file was deleted.

83 changes: 0 additions & 83 deletions chaincode/failurereport/contract_test.go

This file was deleted.

194 changes: 0 additions & 194 deletions chaincode/function/contract.go

This file was deleted.

130 changes: 0 additions & 130 deletions chaincode/function/contract_test.go

This file was deleted.

52 changes: 0 additions & 52 deletions chaincode/info/contract.go

This file was deleted.

35 changes: 0 additions & 35 deletions chaincode/info/contract_test.go

This file was deleted.

146 changes: 0 additions & 146 deletions chaincode/ledger/context.go

This file was deleted.

49 changes: 0 additions & 49 deletions chaincode/ledger/context_test.go

This file was deleted.

288 changes: 0 additions & 288 deletions chaincode/ledger/dbal.go

This file was deleted.

202 changes: 0 additions & 202 deletions chaincode/ledger/dbal_computeplan.go

This file was deleted.

142 changes: 0 additions & 142 deletions chaincode/ledger/dbal_computeplan_test.go

This file was deleted.

Loading