Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make init container image customizable #482

Merged
merged 4 commits into from
Dec 17, 2024
Merged

feat: make init container image customizable #482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
971adaa
feat: make `postgres` customizable
guilhem-barthes Dec 16, 2024
1e53609
feat: bump chart version
guilhem-barthes Dec 16, 2024
ff199b9
fix: make default version a string
guilhem-barthes Dec 17, 2024
ddd0bc1
chore: rename `initImages` values
guilhem-barthes Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/orchestrator/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

<!-- towncrier release notes start -->
## [8.8.0] - 2024-12-16

Make init image (`postgres`) customizable

## [8.7.7] - 2024-10-14

Expand Down
2 changes: 1 addition & 1 deletion charts/orchestrator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: orchestrator
description: substra orchestration
type: application
version: 8.7.7
version: 8.8.0
appVersion: 1.0.0
kubeVersion: '>= 1.19.0-0'
icon: https://avatars.githubusercontent.com/u/84009910?s=400
Expand Down
8 changes: 8 additions & 0 deletions charts/orchestrator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,14 @@ See Bitnami documentation: https://bitnami.com/stack/postgresql/helm
| ----------------------------- | --------------------------------------------------------- | ----- |
| `migrations.fullnameOverride` | String to fully override the `migrations.server.fullname` | `""` |

### Images

| Name | Description | Value |
| ---------------------------------- | ----------------------------------------- | ----------- |
| `initImages.postgresql.repository` | PostgreSQL image | `postgres` |
| `initImages.postgresql.tag` | PostgreSQL tag | `17` |
| `initImages.postgresql.registry` | The registry to pull the PostgreSQL image | `docker.io` |


## Usage

Expand Down
2 changes: 1 addition & 1 deletion charts/orchestrator/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ Disable SSL if using the integrated Postgres, otherwise leave users with the opt

{{- define "substra-orc.waitPostgresqlInitContainer" -}}
- name: wait-postgresql
image: postgres
image: {{ include "substra-orc.images.name" (dict "img" $.Values.initImages.postgresql "defaultTag" "latest") }}
command: ['sh', '-c', 'until pg_isready --host={{ template "substra-orc.database.host" . }} --port={{ .Values.database.port }}; do echo "Waiting for postgresql service"; sleep 2; done;']
securityContext:
allowPrivilegeEscalation: false
Expand Down
11 changes: 11 additions & 0 deletions charts/orchestrator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,3 +321,14 @@ migrations:
## @param migrations.fullnameOverride String to fully override the `migrations.server.fullname`
##
fullnameOverride: ""

## @section Images
##
initImages:
postgresql:
## @param initImages.postgresql.repository PostgreSQL image
## @param initImages.postgresql.tag PostgreSQL tag
## @param initImages.postgresql.registry The registry to pull the PostgreSQL image
registry: docker.io
repository: postgres
tag: "17"
Loading