Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: log on builder celery tasks #713

Closed

Conversation

ThibaultFy
Copy link
Member

@ThibaultFy ThibaultFy commented Aug 22, 2023

Description

closes FL-1146

How has this been tested?

Checklist

  • changelog was updated with notable changes
  • documentation was updated

@ThibaultFy ThibaultFy changed the base branch from main to poc-decoupled-builder August 23, 2023 09:23
@ThibaultFy ThibaultFy force-pushed the chore/log-on-builder-celery-tasks branch from 257c919 to d4fec54 Compare August 23, 2023 09:25
Signed-off-by: ThibaultFy <[email protected]>
@linear
Copy link

linear bot commented Aug 23, 2023

FL-1146 Handle errors logs for building errors

Context

BuildTask on copied from the Celery compute tasks, so the log handler expect a compute task key (which does not exist when building the docker image for a function).

We want to generalize the log error handler to switch from compute task specific, to key + asset_type specific.

We want to rewrite the on_failure function for build_image and save_image.

Specification

Rewrite the store_failure function:

def store_failure(exc: Exception, compute_task_key: str) -> Optional[models.ComputeTaskFailureReport]:
to generalize it from compute_task_key to asset_ket, asset_type.

Update the on_failre method for build image celery task and save image celery task

Acceptance criteria

Logs are accessible for build and save image tasks.

Signed-off-by: ThibaultFy <[email protected]>
Signed-off-by: ThibaultFy <[email protected]>
@SdgJlbl
Copy link
Contributor

SdgJlbl commented Sep 12, 2023

Closed in favour of #727

@SdgJlbl SdgJlbl closed this Sep 12, 2023
@SdgJlbl SdgJlbl deleted the chore/log-on-builder-celery-tasks branch September 12, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants