-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates - Redis and RabbitMQ - metrics collection capability #5088
base: main
Are you sure you want to change the base?
Conversation
…ollection capability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, @sumoanema. I made some minor changes (see commit "Updates from review").
docs/send-data/opentelemetry-collector/remote-management/source-templates/redis/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Amee Lepcha <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumoanema Please add one more point , when user upgrade from lower to latest version of ST from longs only for Logs and metrics. they should refer the pre-requisite and complete the dependency
…o follow prerequisite steps for log collection
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
docs/send-data/opentelemetry-collector/remote-management/source-templates/rabbitmq/index.md
Outdated
Show resolved
Hide resolved
docs/send-data/opentelemetry-collector/remote-management/source-templates/redis/index.md
Outdated
Show resolved
Hide resolved
docs/send-data/opentelemetry-collector/remote-management/source-templates/redis/changelog.md
Outdated
Show resolved
Hide resolved
docs/send-data/opentelemetry-collector/remote-management/source-templates/rabbitmq/changelog.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Kim (Sumo Logic) <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
:::note | ||
Please follow [prerequisites](../#prerequisites) section before upgrading to this version for collecting metrics. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumoanema, the link doesn't go to a prerequisites section. Should it go here? - https://help.sumologic.com/docs/send-data/opentelemetry-collector/remote-management/source-templates/rabbitmq/#prerequisites
|
||
:::note | ||
Please follow [prerequisites](../#prerequisites) section before upgrading to this version for collecting metrics. | ||
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumoanema, the link doesn't go to a prerequisites section. Should it go here? - https://help.sumologic.com/docs/send-data/opentelemetry-collector/remote-management/source-templates/redis/#prerequisites
Purpose of this pull request
Doc update for redis and rabbitmq which are enhanced to have metric collection capability
Select the type of change
Ticket (if applicable)
https://sumologic.atlassian.net/browse/SUMO-245193