Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base64encode.md #5117

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update base64encode.md #5117

wants to merge 2 commits into from

Conversation

JV0812
Copy link
Collaborator

@JV0812 JV0812 commented Feb 27, 2025

Purpose of this pull request

This pull request is to update the base64Encoding doc as we now support non-ASCII values.

Select the type of change

  • Minor Changes - Typos, formatting, slight revisions
  • Update Content - Revisions, updating sections
  • New Content - New features, sections, pages, tutorials
  • Site and Tools - .clabot, version updates, maintenance, dependencies, new packages for the site (Docusaurus, Gatsby, React, etc.)

Ticket (if applicable)

Document base64 encoding support of non ascii characters.

@cla-bot cla-bot bot added the cla-signed Contributor approved, listed in .clabot file label Feb 27, 2025
@JV0812 JV0812 self-assigned this Feb 27, 2025
@JV0812 JV0812 added the do-not-merge Pull requests that should not be merged label Feb 27, 2025
@@ -3,8 +3,7 @@ id: base64encode
title: base64Encode Search Operator
sidebar_label: base64Encode
---

The `base64Encode` operator takes an ASCII string and converts it to a base64 string.
The `base64Encode` operator takes an ASCII or non-ASCII string and converts it to base64 string.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The `base64Encode` operator takes an ASCII or non-ASCII string and converts it to base64 string.
The `base64Encode` operator takes an ASCII or non-ASCII string and converts it to a base64 string.

The Base64Encode function supports encoding non-ASCII characters in addition to ASCII. The following example returns `base64` with a value of `5LiWIOOCiOOBhOOBoQ==`:

```sql
| base64encode("世 よいち") as base64
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| base64encode("世 よいち") as base64
| base64encode("世 よいち") as base64

```

:::note
Make sure that the encoding format you are using matches the one with decoding.
Copy link
Collaborator

@kimsauce kimsauce Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Make sure that the encoding format you are using matches the one with decoding.
Make sure that the encoding format you use matches the decoding format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed Contributor approved, listed in .clabot file do-not-merge Pull requests that should not be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants