Issue #KN-517 feat: Epub player Web component output updation

Sunbird-Knowlg · Nov 8, 2022 · f649b9a · f649b9a
1 parent a0a2055
commit f649b9a
Show file tree

Hide file tree

Showing 5 changed files with 2,131 additions and 150,369 deletions.
diff --git a/angular.json b/angular.json
@@ -44,7 +44,7 @@
             "vendorChunk": true,
             "extractLicenses": false,
             "buildOptimizer": false,
-            "optimization": false,
+            "optimization": true,
             "namedChunks": true
           },
           "configurations": {
@@ -215,7 +215,7 @@
             "extractLicenses": false,
             "buildOptimizer": false,
             "sourceMap": true,
-            "optimization": false,
+            "optimization": true,
             "namedChunks": true
           },
           "configurations": {

diff --git a/projects/sunbird-epub-player/src/lib/sunbird-epub-player.component.spec.ts b/projects/sunbird-epub-player/src/lib/sunbird-epub-player.component.spec.ts
@@ -1,11 +1,12 @@
-import { NO_ERRORS_SCHEMA } from '@angular/core';
+import { NO_ERRORS_SCHEMA, SimpleChanges, SimpleChange } from '@angular/core';
 import { ComponentFixture, TestBed, waitForAsync } from '@angular/core/testing';
 import { ViwerService } from './services/viewerService/viwer-service';
 import { mockData } from './services/viewerService/viwer-service.spec.data';
 
 import { EpubPlayerComponent } from './sunbird-epub-player.component';
 import { EpubPlayerService } from './sunbird-epub-player.service';
 import { epubPlayerConstants, telemetryType } from './sunbird-epub.constant';
+import { HttpClientTestingModule } from '@angular/common/http/testing';
 
 
 
@@ -17,6 +18,7 @@ describe('EpubPlayerComponent', () => {
   beforeEach(waitForAsync(() => {
     TestBed.configureTestingModule({
       declarations: [EpubPlayerComponent],
+      imports: [HttpClientTestingModule],
       schemas: [NO_ERRORS_SCHEMA],
       providers: [ViwerService, EpubPlayerService]
     })
@@ -140,4 +142,24 @@ describe('EpubPlayerComponent', () => {
     jasmine.clock().tick(11);
     expect(component.progress).toEqual(30);
   });
+  it('should call ngOnChanges and call ngOnInit when isInitialized is true', () => {
+    component.isInitialized = true;
+    const changes: SimpleChanges = {
+      action: new SimpleChange('play', 'view', true),
+      playerConfig: new SimpleChange('play', 'view', true)
+    };
+    spyOn(component, 'ngOnInit');
+    component.ngOnChanges(changes);
+    expect(component.ngOnInit).toHaveBeenCalled();
+  });
+  it('should call ngOnChanges and should not call ngOnInit when isInitialized is false', () => {
+    component.isInitialized = false;
+    const changes: SimpleChanges = {
+      action: new SimpleChange('play', 'view', true),
+      playerConfig: new SimpleChange('play', 'view', true)
+    };
+    spyOn(component, 'ngOnInit');
+    component.ngOnChanges(changes);
+    expect(component.ngOnInit).not.toHaveBeenCalled();
+  });
 });
diff --git a/projects/sunbird-epub-player/src/lib/sunbird-epub-player.component.ts b/projects/sunbird-epub-player/src/lib/sunbird-epub-player.component.ts
@@ -34,6 +34,7 @@ export class EpubPlayerComponent implements OnInit, OnChanges, OnDestroy, AfterV
     showExit: false,
     showPrint: false
   };
+  public isInitialized = false;
   viewState = this.fromConst.LOADING;
   intervalRef: any;
   progress = 0;
@@ -63,14 +64,16 @@ export class EpubPlayerComponent implements OnInit, OnChanges, OnDestroy, AfterV
   }
 
   async ngOnInit() {
+    this.isInitialized = true;
+    if (this.playerConfig) {
     if (typeof this.playerConfig === 'string') {
       try {
         this.playerConfig = JSON.parse(this.playerConfig);
       } catch (error) {
         console.error('Invalid playerConfig: ', error);
       }
     }
-
+  }
     // initializing services
     this.viwerService.initialize(this.playerConfig);
     this.epubPlayerService.initialize(this.playerConfig);
@@ -103,6 +106,10 @@ export class EpubPlayerComponent implements OnInit, OnChanges, OnDestroy, AfterV
     if (changes.showFullScreen && !changes?.showFullScreen?.firstChange) {
       this.showFullScreen = changes.showFullScreen.currentValue;
     }
+    if (changes.playerConfig.firstChange && this.isInitialized) {
+      // Calling for web component explicitly and life cycle works in different order
+      this.ngOnInit();
+    }
   }
   ngAfterViewInit() {
     const epubPlayerElement = this.epubPlayerRef.nativeElement;