Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWED-2336 radio buttons UI #975

Merged
merged 11 commits into from
Apr 24, 2024
Merged

Conversation

goldenraphti
Copy link
Collaborator

Before merge:

  • add silent support for
  • refactor

Optional:

  • add E2E tests

Description

Jira SWED-2336: https://payexjira.atlassian.net/browse/SWED-2336
Components Figma prototypes: https://www.figma.com/file/gIzOUSzoQcVsExTO6DZpW4/Components?type=design&node-id=11496-12702&mode=design&t=6z9QPU0qmzCOgzRa-0

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

Copy link

github-actions bot commented Apr 23, 2024

Size Change: +2.34 kB (0%)

Total Size: 1.15 MB

Filename Size Change
dist/designguide/styles/payex.css 50.3 kB +592 B (+1%)
dist/designguide/styles/swedbankpay.css 47.7 kB +573 B (+1%)
dist/styles/payex.css 50.3 kB +592 B (+1%)
dist/styles/swedbankpay.css 47.7 kB +573 B (+1%)
ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.7 kB 0 B
dist/designguide/styles/documentation-payex.css 10.1 kB +6 B (0%)
dist/designguide/styles/documentation-swedbankpay.css 9.13 kB 0 B
dist/scripts/3563.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.7 kB 0 B
dist/scripts/payex.js 323 kB 0 B
dist/scripts/swedbankpay.js 323 kB 0 B
dist/styles/documentation-payex.css 10.1 kB +6 B (0%)
dist/styles/documentation-swedbankpay.css 9.13 kB 0 B

compressed-size-action

],
},
// {
// id: "radio_group_type",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

@goldenraphti goldenraphti marked this pull request as ready for review April 24, 2024 09:30
@goldenraphti goldenraphti merged commit c115000 into develop Apr 24, 2024
7 of 8 checks passed
@github-actions github-actions bot deleted the feature/SWED-2336-radio_buttons_ui branch April 24, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant