Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/image builder api #614
base: kpack-resources
Are you sure you want to change the base?
Feat/image builder api #614
Changes from 21 commits
e802870
22749bc
2ffa0ae
8d01b4c
8708ee5
dada2a8
15d1041
35705e4
651beed
3e945bf
9cd24a9
c96cfae
739f3a9
35e86de
127e5f0
ce620e0
3f3adc9
c3f092e
24e8145
05a69b1
b5cbfc2
622accd
a4c4c06
afc5b6f
b5971db
c8fc993
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: We can replace this with
EnvironmentWithImageGet
and not break the API.EnvironmentWithImageGet
just has two extra mandatory fields overEnvironment
. That isenvironment_image_source
andenvironment_kind
. And the addition of those two would be useful too.