-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct uid/gid when cloning git repos #635
Conversation
Pull Request Test Coverage Report for Build 13180787014Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Let's deploy this to check that it works as intended.
You can access the deployment of this PR at https://renku-ci-ds-635.dev.renku.ch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The container to fix is git-clone
. The git-proxy
container should not be updated (it does not touch the file system).
components/renku_data_services/notebooks/api/amalthea_patches/git_proxy.py
Outdated
Show resolved
Hide resolved
components/renku_data_services/notebooks/api/amalthea_patches/git_proxy.py
Outdated
Show resolved
Hide resolved
6aad694
to
645bd11
Compare
645bd11
to
d492320
Compare
This was hardcoded for the old sessions so we just re-used the same hardcoded values from v1 sessions. But for v2 we should take this info from the environment.
d492320
to
bc16eec
Compare
Well jupyter still does not work when you use non 1001 uid and gid. I see this error in the logs:
But that is not our fault. At least we are doing the right thing and respecting the stuff the user setup. Some images will only work with specific uid/gid. |
So I tested with vscode and that works with gid/uid 1001. See this project for example: https://renku-ci-ds-635.dev.renku.ch/v2/projects/tasko.olevski/test1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Thanks 👍
Tearing down the temporary RenkuLab deplyoment for this PR. |
This was hardcoded for the old sessions so we just re-used the same hardcoded values from v1 sessions. But for v2 we should take this info from the environment.
closes #629
/deploy