-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move V1 URLs #3505
Move V1 URLs #3505
Conversation
a6f1dbe
to
1f612d1
Compare
You can access the deployment of this PR at https://renku-ci-ui-3505.dev.renku.ch |
8e23d07
to
814ef0f
Compare
a046905
to
3403c57
Compare
3403c57
to
71a1f3e
Compare
71a1f3e
to
845d0d2
Compare
845d0d2
to
aa2aec6
Compare
7a4bec5
to
bad78cd
Compare
bad78cd
to
9f54acb
Compare
9f54acb
to
0c752ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some first comments:
client/src/features/dashboard/components/InactiveKgProjects.tsx
Outdated
Show resolved
Hide resolved
The failing acceptance test is because of https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ It can be ignored for the moment, I will fix that later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but in many places hard-coded routes should probably be replaced by the constants defined in ABSOLUTE_ROUTES
.
Tearing down the temporary RenkuLab deplyoment for this PR. |
* /help -> /v1/help * /inactive-kg-projects -> /v1/inactive-kg-projects * /notifications -> /v1/notifications * /projects/new/ -> /v1/projects/new * /projects -> /v1/projects/ (project listing/GitLab search, urls for project pages are unchanged) * /projects/all -> /v1/projects/all * /projects/starred -> /v1/projects/starred * /search -> /v1/search
Move V1 URLs to legacy locations
URLs for projects and datasets are kept, but other URLs are moved to new locations to make room to be replaced with V2 pages.
/help
->/v1/help
/inactive-kg-projects
->/v1/inactive-kg-projects
/notifications
->/v1/notifications
/projects/new/
->/v1/projects/new
/projects
->/v1/projects/
(project listing/GitLab search, urls for project pages are unchanged)/projects/all
->/v1/projects/all
/projects/starred
->/v1/projects/starred
/search
->/v1/search
/deploy renku=ciyer/urls-v1-v2