Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move V1 URLs #3505

Merged
merged 11 commits into from
Jan 31, 2025
Merged

Move V1 URLs #3505

merged 11 commits into from
Jan 31, 2025

Conversation

ciyer
Copy link
Contributor

@ciyer ciyer commented Jan 24, 2025

Move V1 URLs to legacy locations

URLs for projects and datasets are kept, but other URLs are moved to new locations to make room to be replaced with V2 pages.

  • /help -> /v1/help
  • /inactive-kg-projects -> /v1/inactive-kg-projects
  • /notifications -> /v1/notifications
  • /projects/new/ -> /v1/projects/new
  • /projects -> /v1/projects/ (project listing/GitLab search, urls for project pages are unchanged)
  • /projects/all -> /v1/projects/all
  • /projects/starred -> /v1/projects/starred
  • /search -> /v1/search

/deploy renku=ciyer/urls-v1-v2

@ciyer ciyer force-pushed the ciyer/move-v1-urls branch 3 times, most recently from a6f1dbe to 1f612d1 Compare January 27, 2025 09:53
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 27, 2025 10:26 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3505.dev.renku.ch

@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 27, 2025 11:33 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 27, 2025 12:00 — with GitHub Actions Inactive
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 28, 2025 09:42 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/move-v1-urls branch from a046905 to 3403c57 Compare January 29, 2025 08:31
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 29, 2025 08:32 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/move-v1-urls branch from 3403c57 to 71a1f3e Compare January 29, 2025 08:52
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 29, 2025 08:52 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/move-v1-urls branch from 71a1f3e to 845d0d2 Compare January 29, 2025 09:20
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 29, 2025 09:20 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/move-v1-urls branch from 7a4bec5 to bad78cd Compare January 30, 2025 10:38
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 30, 2025 10:38 — with GitHub Actions Inactive
@ciyer ciyer marked this pull request as ready for review January 30, 2025 10:44
@ciyer ciyer requested a review from a team as a code owner January 30, 2025 10:44
@leafty leafty self-assigned this Jan 30, 2025
@ciyer ciyer force-pushed the ciyer/move-v1-urls branch from bad78cd to 9f54acb Compare January 30, 2025 12:29
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 30, 2025 12:29 — with GitHub Actions Inactive
@ciyer ciyer force-pushed the ciyer/move-v1-urls branch from 9f54acb to 0c752ed Compare January 30, 2025 12:37
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 30, 2025 12:37 — with GitHub Actions Inactive
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first comments:

README.md Show resolved Hide resolved
client/src/App.jsx Outdated Show resolved Hide resolved
client/src/components/navbar/NavBarItems.tsx Outdated Show resolved Hide resolved
client/src/features/rootV1/LazyProjectRootV1.tsx Outdated Show resolved Hide resolved
client/src/features/rootV1/ProjectRootV1.tsx Outdated Show resolved Hide resolved
@ciyer ciyer temporarily deployed to renku-ci-ui-3505 January 30, 2025 13:24 — with GitHub Actions Inactive
@ciyer
Copy link
Contributor Author

ciyer commented Jan 30, 2025

The failing acceptance test is because of https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ It can be ignored for the moment, I will fix that later.

Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but in many places hard-coded routes should probably be replaced by the constants defined in ABSOLUTE_ROUTES.

client/src/App.jsx Show resolved Hide resolved
client/src/landing/NavBar.jsx Outdated Show resolved Hide resolved
client/src/not-found/NotFound.tsx Show resolved Hide resolved
client/src/websocket/handlers/kgActivationStatusHandler.ts Outdated Show resolved Hide resolved
@ciyer ciyer merged commit 75b525d into build/urls-v1-v2 Jan 31, 2025
10 of 19 checks passed
@ciyer ciyer deleted the ciyer/move-v1-urls branch January 31, 2025 10:44
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

ciyer added a commit that referenced this pull request Jan 31, 2025
* /help -> /v1/help
* /inactive-kg-projects -> /v1/inactive-kg-projects
* /notifications -> /v1/notifications
* /projects/new/ -> /v1/projects/new
* /projects -> /v1/projects/ (project listing/GitLab search, urls for project pages are unchanged)
* /projects/all -> /v1/projects/all
* /projects/starred -> /v1/projects/starred
* /search -> /v1/search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants