Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use API code generators for sessions v2 #3513

Merged
merged 12 commits into from
Jan 30, 2025

Conversation

leafty
Copy link
Member

@leafty leafty commented Jan 28, 2025

Merging into the build/session-env-builders feature branch.

This refactor updates the sessions v2 API to use generated code from the API spec. This is done to allow for the API files to be easily updated after changes from the backend services.

/deploy

@leafty leafty temporarily deployed to renku-ci-ui-3513 January 29, 2025 12:07 — with GitHub Actions Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-3513.dev.renku.ch

@leafty leafty temporarily deployed to renku-ci-ui-3513 January 29, 2025 12:31 — with GitHub Actions Inactive
@leafty leafty changed the base branch from main to build/session-env-builders January 29, 2025 12:45
@leafty leafty marked this pull request as ready for review January 29, 2025 12:48
@leafty leafty requested a review from a team as a code owner January 29, 2025 12:48
@ciyer ciyer self-assigned this Jan 30, 2025
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This makes things easier to work with, and the split of the API between sessions and session launchers makes things more logical as well.

@leafty
Copy link
Member Author

leafty commented Jan 30, 2025

Looks good! This makes things easier to work with, and the split of the API between sessions and session launchers makes things more logical as well.

The split exists because the API spec itself is split between two files as well.

@leafty leafty merged commit 67b25e4 into build/session-env-builders Jan 30, 2025
29 of 36 checks passed
@leafty leafty deleted the leafty/session-env-builders-4 branch January 30, 2025 09:50
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants