Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain AssetMapper 6.4 #26

Closed

Conversation

bocharsky-bw
Copy link
Member

@bocharsky-bw bocharsky-bw commented Oct 30, 2023

In order to fix PhpStan error in #23

Run vendor/bin/phpstan analyse
Note: Using configuration file /home/runner/work/sass-bundle/sass-bundle/phpstan.neon.dist.
 0/7 [░░░░░░░░░░░░░░░░░░░░░░░░░░░░]   0%
 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] [10](https://github.com/SymfonyCasts/sass-bundle/actions/runs/6655476098/job/18179258827?pr=23#step:5:11)0%

Error: Call to an undefined method Symfony\Component\AssetMapper\Path\PublicAssetsPathResolverInterface::getPublicFilesystemPath().
 ------ -------------------------------------------------------------------------------------------------- 
  Line   AssetMapper/SassPublicPathAssetPathResolver.php                                                   
 ------ -------------------------------------------------------------------------------------------------- 
  33     Call to an undefined method                                                                       
         Symfony\Component\AssetMapper\Path\PublicAssetsPathResolverInterface::getPublicFilesystemPath().  
 ------ -------------------------------------------------------------------------------------------------- 


Error:  [ERROR] Found 1 error                                                          

Error: Process completed with exit code 1.

Seems getPublicFilesystemPath() is gone from the Symfony\Component\AssetMapper\Path\PublicAssetsPathResolverInterface in 6.4. I suppose we should release this fix, and then drop getPublicFilesystemPath() from ours SassPublicPathAssetPathResolver() as well and release it again?

Any thoughts?

@WebMamba
Copy link
Contributor

WebMamba commented Oct 30, 2023

I think we should not completly drop the support. You have a working example of the phpstan fix here: #22

@bocharsky-bw
Copy link
Member Author

Hm, I see now... probably suggest to upgrade sass bundle in the throwing exception when method does not exist?

@WebMamba
Copy link
Contributor

It should never reach the exception. It's only to fool phpstan

@bocharsky-bw
Copy link
Member Author

With latest asset mapper but older sass bundle it's pretty possible I think.

OK, closing it in favor of #22

@bocharsky-bw bocharsky-bw deleted the constrain-asset-mapper branch October 31, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants