Deprecated getPublicFilesystemPath in SassPublicPathAssetPathResolver, fixes phpstan suite #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evertharmeling
force-pushed
the
phpstan
branch
2 times, most recently
from
b34fecd to
c2c3892
Compare
evertharmeling
changed the title
evertharmeling
force-pushed
the
phpstan
branch
from
c2c3892 to
80b7e8b
Compare
… as it is removed from PublicAssetsPathResolverInterface
evertharmeling
force-pushed
the
phpstan
branch
from
80b7e8b to
0554dde
Compare
|
The problem with PHPStan error was fixed in a different way in #22 - we need to revert this here now. Actually, it seems we should just close this because we get rid of that silently, and it will throw anyway |
|
Ah right missed that PR, sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PHPStan error is caused because of the removal of
getPublicFilesystemPathinPublicAssetsPathResolverInterface.Removing the method here also fixes the phpstan error.Guess since this bundle is still in it's0.xmajor version we could just follow theasset-mappercomponent? Or do we need to deprecate the method and add an ignore in the phpstan config and remove it in the1.xversion?edit: Deprecated the function and added an ignore to phpstan