feat(svm): PQR support #501
Open
+626
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Rexicon226
force-pushed
the
Rexicon226/sbpfv2
branch
from
86a63fe to
ac6d79a
Compare
Rexicon226
force-pushed
the
Rexicon226/svm-pqr
branch
from
87477cc to
2a8cf89
Compare
Rexicon226
force-pushed
the
Rexicon226/sbpfv2
branch
from
a15694e to
a5a2d79
Compare
Rexicon226
force-pushed
the
Rexicon226/svm-pqr
branch
from
2a8cf89 to
77518dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the PQR (product, quotient, remainder) extension which was described here: solana-foundation/solana-improvement-documents#174.
Other than that, it's just a lot of tests to ensure the implementation of the extension is correct and matches other SVMs and a bit of cleanup in the ELF parser to replace more call sites with safe slicing, to prevent panics from invalid input.