fix(ledger,shred-network): memory leak

build.zig.zon

@@ -28,8 +28,8 @@
             .hash = "122030ebe280b73693963a67ed656226a67b7f00a0a05665155da00c9fcdee90de88",
         },
         .rocksdb = .{
-            .url = "https://github.com/Syndica/rocksdb-zig/archive/6d4230e131183cccb730a7248bd4ca30c559b8bd.tar.gz",
-            .hash = "12207766d25ba350d6e2f2153fc74a2b3ff204224e1c08adf211cd9e400075033898",
+            .url = "https://github.com/Syndica/rocksdb-zig/archive/cf966c0c6bb6205a08bb2006f399719542e4e770.tar.gz",
+            .hash = "1220d25e3ef18526cb6c980b441f05dc96330bedd88a512dcb3aed775a981ce3707d",
         },
         .lsquic = .{
             .url = "https://github.com/Syndica/lsquic/archive/ed6ced0cbc6447f7135a32db491e398debdf8af7.tar.gz",

src/ledger/benchmarks.zig

@@ -58,7 +58,8 @@ pub const BenchmarkLedger = struct {
         }
 
         var timer = try sig.time.Timer.start();
-        _ = try inserter.insertShreds(shreds, is_repairs, null, false, null, null);
+        const result = try inserter.insertShreds(shreds, is_repairs, .{});
+        defer result.deinit();
         return timer.read();
     }
 
@@ -112,7 +113,9 @@ pub const BenchmarkLedger = struct {
 
         const total_shreds = shreds.len;
 
-        _ = try ledger.shred_inserter.shred_inserter.insertShredsForTest(&inserter, shreds);
+        const result = try ledger.shred_inserter.shred_inserter
+            .insertShredsForTest(&inserter, shreds);
+        result.deinit();
 
         const slot: u32 = 0;
         const num_reads = total_shreds / 15;
@@ -141,7 +144,9 @@ pub const BenchmarkLedger = struct {
         defer deinitShreds(allocator, shreds);
 
         const total_shreds = shreds.len;
-        _ = try ledger.shred_inserter.shred_inserter.insertShredsForTest(&inserter, shreds);
+        const result = try ledger.shred_inserter.shred_inserter
+            .insertShredsForTest(&inserter, shreds);
+        result.deinit();
         const num_reads = total_shreds / 15;
 
         const slot: u32 = 0;
@@ -166,7 +171,7 @@ pub const BenchmarkLedger = struct {
         defer state.deinit();
         var reader = try state.reader();
         const result = try ledger_tests.insertDataForBlockTest(state);
-        defer result.deinit();
+        result.deinit();
 
         var timer = try sig.time.Timer.start();
         _ = try reader.getCompleteBlock(result.slot + 2, true);
@@ -178,7 +183,7 @@ pub const BenchmarkLedger = struct {
         defer state.deinit();
         var reader = try state.reader();
         const result = try ledger_tests.insertDataForBlockTest(state);
-        defer result.deinit();
+        result.deinit();
 
         var timer = try sig.time.Timer.start();
         const shreds = try reader.getDataShredsForSlot(result.slot + 2, 0);
@@ -192,7 +197,7 @@ pub const BenchmarkLedger = struct {
         defer state.deinit();
         var reader = try state.reader();
         const result = try ledger_tests.insertDataForBlockTest(state);
-        defer result.deinit();
+        result.deinit();
 
         var timer = try sig.time.Timer.start();
         const items = try reader.getSlotEntriesWithShredInfo(result.slot + 2, 0, true);
@@ -213,7 +218,9 @@ pub const BenchmarkLedger = struct {
         defer deinitShreds(allocator, shreds);
 
         const total_shreds = shreds.len;
-        _ = try ledger.shred_inserter.shred_inserter.insertShredsForTest(&inserter, shreds);
+        const result = try ledger.shred_inserter.shred_inserter
+            .insertShredsForTest(&inserter, shreds);
+        result.deinit();
 
         const slot: u32 = 1;
 
@@ -243,7 +250,9 @@ pub const BenchmarkLedger = struct {
         const shreds = try testShreds(std.heap.c_allocator, shreds_path);
         defer deinitShreds(allocator, shreds);
 
-        _ = try ledger.shred_inserter.shred_inserter.insertShredsForTest(&inserter, shreds);
+        const result = try ledger.shred_inserter.shred_inserter
+            .insertShredsForTest(&inserter, shreds);
+        result.deinit();
 
         const slot = 1;
         const start_index = 0;

src/ledger/database/interface.zig

@@ -277,10 +277,17 @@ pub const BytesRef = struct {
     data: []const u8,
     deinitializer: ?Deinitializer = null,
 
-    pub fn deinit(self: @This()) void {
+    pub fn deinit(self: BytesRef) void {
         if (self.deinitializer) |d| d.deinit(self.data);
     }
 
+    pub fn clone(self: BytesRef, allocator: Allocator) Allocator.Error!BytesRef {
+        return .{
+            .data = try allocator.dupe(u8, self.data),
+            .deinitializer = .{ .allocator = allocator },
+        };
+    }
+
     pub const Deinitializer = union(enum) {
         allocator: Allocator,
         rocksdb: *const fn (?*anyopaque) callconv(.C) void,

src/ledger/reader.zig

@@ -2103,7 +2103,7 @@ test "findMissingDataIndexes" {
         .resigned = false,
     };
     shred.data.common.variant = variant;
-    try shred.data.writePayload(&(.{2} ** 100));
+    try ledger.shred.overwriteShredForTest(allocator, &shred, &(.{2} ** 100));
 
     var slot_meta = SlotMeta.init(allocator, shred_slot, null);
     slot_meta.last_index = 4;
@@ -2172,7 +2172,7 @@ test "getCodeShred" {
     shred.code.common.variant = variant;
     shred.code.custom.num_data_shreds = 1;
     shred.code.custom.num_code_shreds = 1;
-    try shred.code.writePayload(&(.{2} ** 100));
+    try ledger.shred.overwriteShredForTest(allocator, &shred, &(.{2} ** 100));
 
     const shred_slot = shred.commonHeader().slot;
     const shred_index = shred.commonHeader().index;