Zoom image from template method for ImageData #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplate' into zoom_image_from_template
KrisThielemans
requested changes
Jan 16, 2025
There was a problem hiding this comment.
some comments, but in addition,
-
there are some weird/unnecessary white-space differences. Please fix/ remove (see the diff on github). Some of this might be caused by editor conventions with tabs vs spaces, but even your own code doesn't like sensible in places.
-
add a line to CHANGES.md
Comment on lines
+1365
to
+1369
| void zoom_image(const STIRImageData& original_image, | ||
| const stir::ZoomOptions zoom_options = stir::ZoomOptions::preserve_sum); | ||
|
|
||
| void zoom_image(const STIRImageData& original_image, | ||
| const char* const zoom_options_str = "preserve_sum"); |
There was a problem hiding this comment.
naming of parameter would have to be template_image. Needs some doxygen as well. Finally, I'd prefer these to be called exactly the same as the Python version. e.g. zoom_image_as_template
| if not isinstance(template, ImageData): | ||
| raise error('zoom_image_from_template: template should be ImageData') | ||
|
|
||
| ### becaus of a bug somewherre |
There was a problem hiding this comment.
misspellings and indentation problems.
| @@ -681,6 +681,24 @@ def zoom_image(self, zooms=(1., 1., 1.), offsets_in_mm=(0., 0., 0.), | |||
| np_offsets_in_mm.ctypes.data, np_size.ctypes.data, scaling)) | |||
|
|
|||
| return zoomed_im | |||
|
|
|||
| def zoom_image_from_template(self, template, scaling='preserve_sum'): | |||
There was a problem hiding this comment.
what about zoom_image_as_template?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Added method for
ImageDatato zoom image using geometrical information from a template imageTesting performed
ImageDatazoomed usingzoom_image_from_template()andzoom_image()with manually calculated arguments (although dimensions will be different).zoom_imageusing stir pythonRelated issues
Checklist before requesting a review
Contribution Notes
Please read and adhere to the contribution guidelines.
Please tick the following: