[FEAT] 로그인박스 추가 #27
Merged
[FEAT] 로그인박스 추가 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
chunzhi23
reviewed
Jul 24, 2024
…top-frontend into feat/7-loginbox
chunzhi23
requested changes
Jul 27, 2024
| gap: 8px; | ||
| position: relative; | ||
| width: 727px; | ||
| height: 570px; |
There was a problem hiding this comment.
로그인박스의 width와 height를 고정해두지 말고
- flexbox로 그대로 둬서 이 컴포넌트를 사용하는 그릇이 맞추게 하거나
- LoginBox props로 width와 height를 받아와서
style={{width: width, height: height}}와 같이 하면 어떨까요?
| margin: 10px 0; | ||
| cursor: pointer; | ||
| width: 600px; | ||
| height: 90px; |
There was a problem hiding this comment.
로그인박스와 마찬가지로 width: 100%처럼 크기를 유동적으로 설정할 수 있게 하면 좋을 것 같습니다.
| <div className={classes.loginBox}> | ||
| <img src="/images/S-TopLogo.png" alt="Logo" className={classes.logo} /> | ||
| <img src="/images/kakaoLoginButton.png" alt="카카오 로그인" className={classes.button} /> | ||
| <img src="/images/naverLoginButton.png" alt="네이버 로그인" className={classes.button} /> |
There was a problem hiding this comment.
로그인 버튼을 이미지 대신 크기가 유동적일 수 있게 Mantine Button을 사용해서 만들면 어떨까요?
leftsection에 아이콘(또는 이미지)를 넣고 스타일로 width를 설정하면 좋을 것 같다는 생각입니다.
There was a problem hiding this comment.
mantine button으로 수정하였습ㄴㅣ다
chqkq
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작성자: @moony1204
체크 리스트
작업 내역
비고