Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 푸터 #28

Merged
merged 2 commits into from
Jul 31, 2024
Merged

[FEAT] 푸터 #28

merged 2 commits into from
Jul 31, 2024

Conversation

chunzhi23
Copy link
Contributor

작성자: @chunzhi23
Issue: #5

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 상단에 이슈 번호를 기입했나요?
  • Target Branch를 올바르게 설정했나요?
  • Label을 알맞게 설정했나요?

작업 내역

  • 푸터 컴포넌트 코드를 작성했습니다.

비고

  • 반응형 디자인을 임시로 만들어 두었습니다. 논의를 통해 추후 보완이 필요해 보입니다.
  • theme color가 figma에 작성되어 있는 것과 조금 차이를 보였기에 hex로 우선 작성했습니다. 추후 보완이 필요합니다.

@chunzhi23 chunzhi23 added the feat label Jul 19, 2024
@chunzhi23 chunzhi23 self-assigned this Jul 19, 2024
@chunzhi23 chunzhi23 requested a review from hynseok July 19, 2024 08:25
Copy link

Copy link
Member

@hynseok hynseok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

푸터는 따로 수정할만한 부분은 없는 것 같습니다.

develop 브랜치에 테마색상 수정해두었는데, 현재 hex로 박혀있는 색상은 pull 해와서 작업하셔도 되고, 머지 후에 작업하셔도 될 것 같습니다.

수고하셨습니다!

@moony1204 moony1204 self-requested a review July 26, 2024 05:16
Copy link
Contributor

@moony1204 moony1204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수정사항 없는 듯 합니다!

Copy link

@chunzhi23 chunzhi23 merged commit dff812d into develop Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants