[FEAT] 필터칩 추가 #34
Merged
[FEAT] 필터칩 추가 #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
chunzhi23
reviewed
Jul 24, 2024
There was a problem hiding this comment.
Tabler Icons를 사용하면 관리가 편할 것 같습니다!
There was a problem hiding this comment.
Tabler Icons를 적용하는 데에 여기를 참고해 작업해주시면 좋겠습니다!
chunzhi23
requested changes
Jul 27, 2024
| )} | ||
| {isReset && ( | ||
| <> | ||
| <ResetIcon /> |
There was a problem hiding this comment.
ResetIcon에 hover 했을 때 cursor: pointer로 모양 바꾼다면 좋을 것 같습니다!
There was a problem hiding this comment.
Tabler Icons를 적용하는 데에 여기를 참고해 작업해주시면 좋겠습니다!
| return ( | ||
| <div className={classes.filterChip} style={{ backgroundColor: isReset ? "#DFE2EB" : bgColor }}> | ||
| {!isReset && <span className={classes.label}>{label}</span>} | ||
| {!isReset && ( |
There was a problem hiding this comment.
{ !isReset && (
<>
...
</>
)}
위와 같이 처리해도 괜찮을 것 같습니다!
There was a problem hiding this comment.
tabler icon 적용하였고 resetchip class 새로 만들어 나누어 리턴하는 방식으로 수정했습니다
|
|
||
| const randomBackgroundColor = () => { | ||
| const colors = ["#DFE2EB", "#D1E4FF", "#F3DAFF"]; | ||
| return colors[Math.floor(Math.random() * colors.length)]; |
There was a problem hiding this comment.
backgroundColor와 color를 FilterChip의 props로 받아오게 하면 좋을 것 같아요!
클립 색상을 어떻게 설정해야 하는지는 추후 논의가 필요할 것 같네요..! 노션에 올려두겠습니다 :)
There was a problem hiding this comment.
요건 그냥 랜덤으로 되게 두었습니다
…top-frontend into feat/7-filterChip
|
고생하셨습니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작성자: @moony1204
체크 리스트
작업 내역
비고