[FEAT] 관리자 게시판 미리보기 컴포넌트 추가 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunzhi23
requested changes
Jul 27, 2024
| <Stack gap={0} align="flex-start" justify="flex-start" className={classes.container}> | ||
| <Flex className={classes.title_bar}> | ||
| <div className={classes.col_icon}> | ||
| <Image alt="table icon" src="/icons/Table.svg" width={24} height={24} /> |
There was a problem hiding this comment.
아이콘이 얇아 잘 보이지 않는 것 같아 다른 아이콘 또는 여기를 참고해 Tabler를 사용하면 좋을 것 같습니다!
| onClick={onClickRow} | ||
| > | ||
| <div className={classes.column_pinned}> | ||
| {pinned && <Image src="/icons/Pin_fill.svg" alt="pinned" width={24} height={24} />} |
There was a problem hiding this comment.
Pin 아이콘도 Tabler에 같은 모양이 있으니 여기를 참고해 편하게 쓰실 수 있을 것 같습니다!
obinox
approved these changes
Aug 7, 2024
늦은 수정 죄송합니다. 마지막 페이지의 경우 dummyRow가 추가로 보여지도록 해서 페이지네이션을 고정시켰습니다. 수정된 코드 확인 부탁드립니다! |
chunzhi23
approved these changes
Aug 9, 2024
| @@ -0,0 +1,42 @@ | |||
| .container { | |||
| width: 600px; | |||
There was a problem hiding this comment.
부모 스타일에 맞게 유동적으로 너비가 변할 수 있도록 width를 고정하지는 않아도 괜찮을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작성자: @sera2002
이슈: #8
체크 리스트
작업 내역
비고
close/resolve/fix #{이슈 번호 기입}