New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] test colors theme of a component remain #49

Merged

chunzhi23 merged 1 commit into develop from fix/48-bug-test-colors-theme-of-a-component-remain

Aug 7, 2024

Contributor

chunzhi23 commented Aug 7, 2024

작성자: @chunzhi23
Issue: #48

체크 리스트

적절한 제목으로 수정했나요?
상단에 이슈 번호를 기입했나요?
Target Branch를 올바르게 설정했나요?
Label을 알맞게 설정했나요?

작업 내역

각 컴포넌트 module.css root에 적용되어있는 색상 변수를 해제
해제한 색상 변수는 추후 참고를 위해 root에 영향을 주지 않으면서 다르게 처리해 표시

비고

컴포넌트 개발에 사용했던 개인 색상 변수를 root에 적용한 채로 그대로 병합해 여러 컴포넌트 색상 적용에 혼선을 주는 오류를 발견했습니다.


          [FIX] #47 root commented

9343b1b

chunzhi23 added the bug label

chunzhi23 self-assigned this

chunzhi23 linked an issue

that may be closed by this pull request

[BUG] test colors theme of a component remain #48

Closed

1 task

github-actions bot commented Aug 7, 2024

🚀storybook: https://669667110ecf1f847fa21749-yyqhztigcw.chromatic.com/

chunzhi23 merged commit e4b25ab into develop

1 check passed

chunzhi23 deleted the fix/48-bug-test-colors-theme-of-a-component-remain branch

August 7, 2024 07:31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug