Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] 드롭다운 수정 #54

Merged
merged 1 commit into from
Aug 9, 2024
Merged

[BUG] 드롭다운 수정 #54

merged 1 commit into from
Aug 9, 2024

Conversation

moony1204
Copy link
Contributor

작성자: @moony1204

체크 리스트

  • 적절한 제목으로 수정했나요?
  • 상단에 이슈 번호를 기입했나요?
  • Target Branch를 올바르게 설정했나요?
  • Label을 알맞게 설정했나요?

작업 내역

  • onOptionClick을 Prop으로 빼는 드롭다운 수정 진행

비고

  • 외부에서 onOptionClick으로 setSelectedOption을 해줘야 합니다(?) 종민 리퀘스트.

fix #53

@moony1204 moony1204 added the bug Something isn't working label Aug 9, 2024
@moony1204 moony1204 requested a review from chunzhi23 August 9, 2024 08:39
@moony1204 moony1204 self-assigned this Aug 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

🚀storybook: https://669667110ecf1f847fa21749-twtzaagqvo.chromatic.com/

chunzhi23
chunzhi23 approved these changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@chunzhi23 chunzhi23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다!

@moony1204 moony1204 requested review from chunzhi23 and chqkq August 9, 2024 08:43
@moony1204 moony1204 merged commit 3021d20 into develop Aug 9, 2024
1 check passed
@chunzhi23 chunzhi23 mentioned this pull request Aug 25, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chqkq chqkq chqkq approved these changes

@chunzhi23 chunzhi23 Awaiting requested review from chunzhi23

Assignees

@moony1204 moony1204

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] 프로젝트 조회에서 드롭다운의 옵션값 조회 불가 관련
3 participants
@moony1204 @chunzhi23 @chqkq