Http-server scaffolding and SubmitRfq handler
#111
Conversation
…to plew.http-server
…rrorDetail. was writing a test but found an issue with how Rfq is created (to be fixed in a separate branch)
phoebe-lew
requested review from
mistermoe,
jiyoonie9,
michaelneale,
KendallWeihe,
ethanwlee and
tomdaffurn
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 85.64% 77.51% -8.14%
==========================================
Files 19 26 +7
Lines 432 556 +124
Branches 41 47 +6
==========================================
+ Hits 370 431 +61
- Misses 40 100 +60
- Partials 22 25 +3
|
| ) | ||
| ) | ||
|
|
||
| } |
There was a problem hiding this comment.
i struggled with figuring out a way to set up fakeOffering/ExchangeApi calls so that we can manipulate when to get back a successful or failure case to write tests. this test suite isn't complete as is because of this at the moment. i'm not sure how we'd set up mocking for this though 🤔
| @@ -0,0 +1,70 @@ | |||
| package tbdex.sdk.httpserver.handlers | |||
There was a problem hiding this comment.
super nit: maybe we could call this test class TbdexHttpServerTest? SubmitRfqTest says we're testing that class / that method, not starting up a server and sending a request w/ a client
There was a problem hiding this comment.
Do you think SubmitRfqEndpointTest is better? Tests for the other endpoints will not go in this file, so it's not really comprehensive of all TbdexHttpServer functionality
No description provided.