Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add /bikeshed command component #30

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Add /bikeshed command component #30

merged 3 commits into from
Aug 11, 2023

Conversation

Eisenwave
Copy link
Contributor

Resolves #27.

image

@Eisenwave Eisenwave added new feature New features freestanding Issues available in/related to freestanding mode labels Aug 11, 2023
jeremy-rifkin
jeremy-rifkin approved these changes Aug 11, 2023
View reviewed changes
Copy link
Member

@jeremy-rifkin jeremy-rifkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, I noticed two quick things that would make the code more consistent with the existing codebase

src/components/bikeshed.ts Outdated Show resolved Hide resolved
src/components/bikeshed.ts Outdated Show resolved Hide resolved
@jeremy-rifkin
Copy link
Member

Thanks!

@jeremy-rifkin jeremy-rifkin merged commit f8ca1da into main Aug 11, 2023
6 checks passed
@jeremy-rifkin jeremy-rifkin deleted the bikeshed branch August 11, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremy-rifkin jeremy-rifkin jeremy-rifkin approved these changes

Assignees
No one assigned
Labels
freestanding Issues available in/related to freestanding mode new feature New features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a /bikeshed command (name subject to bike shedding) for creating WG-style polls
2 participants
@Eisenwave @jeremy-rifkin