Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat/#5] 탭바 UI 생성 #7
[Feat/#5] 탭바 UI 생성 #7
Changes from 15 commits
ee6ef99
03d035e
e794227
8ea9aef
2e28031
95a0863
1ed4123
541acd4
bd0d07f
5170559
47dcbcf
5bf2158
095b8ea
463bb0f
a22738b
66a1de7
89933e9
434eaf5
ae1f2d5
bf43333
631cee7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
사소한 부분이지만, 여기 역시 피그마랑 레이아웃이 좀 달라요!
아이콘이랑 글자 사이 간격이 있잖아요 !
여기 패딩을 주고 싶다면....
아래에 패딩이 필요하니까...
저라면 .padding(.bottom, 9)로 둘 거 같아요 !
참고만 해주세요~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 확인하면서 피그마에 있는 디자인이 살짝 대칭이 안맞는거 발견해서...
디자이너님께 요청해서 수정했어요!
패딩 확인하시면서 다시 한번 봐주세요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@agseou 최대한 피그마 확인하면서 padding 넣고 수치 맞춰봤습니다...
번거로우시겠지만 re-request 요청 보낼테니 한 번만 확인 부탁드려요!
늘 감사합니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기에 offset을 둔 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
눈으로 봤을 때 아이콘들이 너무 아래로 치우쳐진 것 같아서 넣어뒀었는데 코드 수정하다보니 전처럼 아예 아래로 치우치는 느낌이 없어져서 삭제했습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
다시 보니까 프로토타입에 비해서는 확실히 아래로 치우치는 느낌이 있어서 padding을 넣었습니다
re-request 요청 보낼테니 한 번만 확인 부탁드려요...!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
offset은 화면에 렌더링할 때만 이동시키는 역할을 해줘요
즉, 뷰의 원래 프레임은 변하지 않고, 화면에 보이는 위치만 이동하거등요!!
특히 버튼과 같은 아이들.. 상호작용이 있는 것들의
실제 뷰 레이아웃 위치를 변경하려면 offset보다는
padding, frame 등을 사용하는게 좋다고 생각합니다 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
자꾸 오류가 나서 찾아보니 변수를 넘겨줄 떄 .constant를 쓰는 방법으로 하게 되었어요... 다른 방법이 있다면 알려주실 수 있을까욥? 🥹
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지금 이 파일에서
@Binding
을 쓰고 있잖아요!혹시
@Binding
이 필요한 이유에 대해 공유해주실 수 있나요?