Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12588] Added unit tests for ExtensionConfirmModalComponent - average coverage 98% #12622

Merged
merged 9 commits into from
Dec 4, 2023
Merged

[#12588] Added unit tests for ExtensionConfirmModalComponent - average coverage 98% #12622

merged 9 commits into from
Dec 4, 2023

Conversation

MatheuMa
Copy link
Contributor

@MatheuMa MatheuMa commented Oct 25, 2023 •
edited by weiquu
Loading

Part of #12588

Outline of Solution
Added unit tests for ExtensionConfirmModalComponent, missed three branches, average coverage 98 - 99%

cedricongjh
cedricongjh requested changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes, and also it appears that onConfirm, setInstructorRowData , setInstructorColumnData, setInstructorTableData is not being tested (while these are tested through snapshots, it would be good to test via code as well)

src/web/app/components/extension-confirm-modal/extension-confirm-modal.component.spec.ts Show resolved Hide resolved
src/web/app/components/extension-confirm-modal/extension-confirm-modal.component.spec.ts Outdated Show resolved Hide resolved
@MatheuMa @cedricongjh
Update src/web/app/components/extension-confirm-modal/extension-confi…
cdc1768 
…rm-modal.component.spec.ts


Thank you for fixing this!

Co-authored-by: Cedric Ong <[email protected]>
@MatheuMa
Copy link
Contributor Author

what happened? I just accpet your change of a single string? I think we didn't do anything wrong?

@cedricongjh
Copy link
Contributor

what happened? I just accpet your change of a single string? I think we didn't do anything wrong?

no worries, our unstable E2E tests fail sometimes when it should not, i'll be re-running it and it should pass!

@cedricongjh cedricongjh added the s.ToReview The PR is waiting for review(s) label Oct 25, 2023
@MatheuMa
Copy link
Contributor Author

MatheuMa commented Oct 25, 2023 •
edited
Loading

I added more tests according to your advice, and also added tests for setStudentRowData , setStudentColumnData, setStudentTableData! By the way this is my first issue, I did learned from this experience, thank you for your review!

@MatheuMa MatheuMa requested a review from cedricongjh October 25, 2023 14:22
cedricongjh
cedricongjh requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great to hear that the experience was fruitful for you!

just a few more changes!

src/web/app/components/extension-confirm-modal/extension-confirm-modal.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/extension-confirm-modal/extension-confirm-modal.component.spec.ts Outdated Show resolved Hide resolved
src/web/app/components/extension-confirm-modal/extension-confirm-modal.component.spec.ts Outdated Show resolved Hide resolved
@MatheuMa MatheuMa requested a review from cedricongjh October 27, 2023 06:35
cedricongjh
cedricongjh approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@cedricongjh cedricongjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you for your contribution to TEAMMATES

@cedricongjh cedricongjh added s.FinalReview The PR is ready for final review and removed s.ToReview The PR is waiting for review(s) labels Oct 28, 2023
@cedricongjh cedricongjh self-assigned this Oct 28, 2023
@cedricongjh cedricongjh mentioned this pull request Oct 28, 2023
Open
@github-actions github-actions bot mentioned this pull request Oct 28, 2023
Open
@MatheuMa
Copy link
Contributor Author

I really appretiate your patience for my code and comments!!!

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

1 similar comment
@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 7 days). 🐌 😢
Hope someone can get it to move forward again soon...

@nusoss-bot
Copy link

Folks, This PR seems to be stalling (no activities for the past 11 days). 🐌 😢
Hope someone can get it to move forward again soon...

weiquu
weiquu approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@weiquu weiquu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@weiquu weiquu removed the request for review from jasonqiu212 December 4, 2023 07:19
@weiquu weiquu added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Dec 4, 2023
@weiquu weiquu merged commit bfcd355 into TEAMMATES:master Dec 4, 2023
8 checks passed
@wkurniawan07 wkurniawan07 added the c.Task Other non-user-facing works, e.g. refactoring, adding tests label Jan 21, 2024
@wkurniawan07 wkurniawan07 added this to the V8.30.0 milestone Jan 21, 2024
cedricongjh added a commit to cedricongjh/teammates that referenced this pull request Feb 20, 2024
@MatheuMa @cedricongjh @weiquu
[TEAMMATES#12588] Added unit tests for ExtensionConfirmModalComponent…
c930938 
… - average coverage 98% (TEAMMATES#12622)

* All coverages are 100%, except branch, 94%

* lint format passed

* Update src/web/app/components/extension-confirm-modal/extension-confirm-modal.component.spec.ts

Thank you for fixing this!

Co-authored-by: Cedric Ong <[email protected]>

* Added tests for every advice (and more

* StudentRow and InstructorRow optimised

* changes according to lint

---------

Co-authored-by: Cedric Ong <[email protected]>
Co-authored-by: Wei Qing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weiquu weiquu weiquu approved these changes

@cedricongjh cedricongjh cedricongjh approved these changes

Assignees

@cedricongjh cedricongjh

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
V8.30.0
Development

Successfully merging this pull request may close these issues.
5 participants
@MatheuMa @cedricongjh @nusoss-bot @weiquu @wkurniawan07