[#12048] Add config for e2e sql tests #12764
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add artillery test
fix branch
use checkout v2
Create playwright e2e workflow
…MATES#12597) * [TEAMMATES#12588] Added unit tests to CourseEditForm component * [TEAMMATES#12588] Added unit tests to CourseEditForm component * [TEAMMATES#12597] Incorporated the review comments for improving code coverage course-edit-form component * [TEAMMATES#12588] Added unit tests to CourseEditForm component * [TEAMMATES#12588] Added unit tests to CourseEditForm component * [TEAMMATES#12597] Incorporated the review comments for improving code coverage course-edit-form component * [TEAMMATES#12597] Incorporated the review comments for improving code coverage course-edit-form component --------- Co-authored-by: Cedric Ong <[email protected]>
…MATES#12613) * add tests * fix the code * fix lines * delete few tests * add the test again * delete the test again to pass test * add the test again * add the test & fix whole structure * fix minor things * fix minor things * fix minor things
* return new map to ensure updates are persisted to db * make changes * revert indentation * add clear Objectify cache method to BaseTestCase * fix checkstyle issues
* change to class... * fix axe tests * e2e test fix * add role * test e2e fix * e2e * add assertion debug * test * cleanup * update snapshots and lint * linkt
…S#12610) * [TEAMMATES#12588] Added unit tests for ErrorReportComponent * [TEAMMATES#12588] Added unit tests for ErrorReportComponent * [TEAMMATES#12588] Added unit tests for ErrorReportComponent * [TEAMMATES#12588] Added unit tests for ErrorReportComponent * [TEAMMATES#12588] Fixed Added unit tests for ErrorReportComponent --------- Co-authored-by: Wei Qing <[email protected]>
…down menu cutoff on mobile (TEAMMATES#12611) Co-authored-by: u7347103 <[email protected]> Co-authored-by: Wei Qing <[email protected]>
…mponent (TEAMMATES#12604) * add unit test for every method in CommentEditFormComponent * fix errors * delete empty line * spys assigned to a const comments removed added test for the ngOnInit() method * fix code style * fix code style --------- Co-authored-by: HarryLu <[email protected]> Co-authored-by: Wei Qing <[email protected]>
…nt (TEAMMATES#12612) * Add unit test for every method in comment-row.component.spec.ts * [TEAMMATES#12588] Add one unit test in comment-row.component.spec.ts * [TEAMMATES#12588] Update on unit test in comment-row.component.spec.ts * [TEAMMATES#12588] Update on small typo in comment-row.component.spec.ts * [TEAMMATES#12588] Update on small change in comment-row.component.spec.ts * [TEAMMATES#12588] Add unit test for every method in recipient-type-name.pipe.spec.ts * [TEAMMATES#12588] fix some typo * [TEAMMATES#12588] fix some typo * [TEAMMATES#12588] Add some unit test in recipient-type-name.pipe.spec.ts * [TEAMMATES#12588] Fix the error * [TEAMMATES#12588] Fix the error --------- Co-authored-by: Wei Qing <[email protected]>
…nent (TEAMMATES#12616) * commit to checkout * Add test for the 'copy' method and improve the test for 'select' method from partial covered to all covered for CopySessionModalComponent. * remove blank line * add new line at the end of file * removed the old test which running error in CI test * revert the change of spec.ts.snap --------- Co-authored-by: Wei Qing <[email protected]>
…for creating and editing session (TEAMMATES#12617) * mark the session name field mandatory when add a new feedback seesion * Fix linting issues * Update tests related with my changes by modifying snapshot * Mark the 'Name for new session' field mandatory when create by copying --------- Co-authored-by: Wei Qing <[email protected]>
…AMMATES#12609) * Added unit tests to CommentTableModal Component * Fixed test for CommentTableModalComponent * Fixed test for CommentTableModalComponent * fix import on comment-table-modal-compenent tests * Made changes to CommentTableModalComponent tests * Delete space on comment-table-modal.component tests * Added Unit test for sessionEditFormComponent * reverted sessionEditFormComponent tests * fixed issues on session-edit-form-component tests * fixed spacing on sessioneditformcomponent tests * fixed spacing on sessioneditformcomponent tests --------- Co-authored-by: Cedric Ong <[email protected]>
…S#12626) * [TEAMMATES#12588] Add some unit test in recipient-type-name.pipe.spec.ts * [TEAMMATES#12588] Add some unit test in recipient-type-name.pipe.spec.ts * [TEAMMATES#12588] Add some unit test in recipient-type-name.pipe.spec.ts --------- Co-authored-by: Cedric Ong <[email protected]>
….java (TEAMMATES#12638) * added tests * linting and whitespace * fix failing unit test * cleaning * only include default constructor calls * case * localize accessibility test faults * axe testing?? * revert * remove comments * update with Arrays.asList * move assert participant type NONE to constructor * added unit test for generateOptionsFor
…TES#12620) * added character limit to frontend * updated snapshot * Updated snapshot --------- Co-authored-by: Wei Qing <[email protected]>
… - average coverage 98% (TEAMMATES#12622) * All coverages are 100%, except branch, 94% * lint format passed * Update src/web/app/components/extension-confirm-modal/extension-confirm-modal.component.spec.ts Thank you for fixing this! Co-authored-by: Cedric Ong <[email protected]> * Added tests for every advice (and more * StudentRow and InstructorRow optimised * changes according to lint --------- Co-authored-by: Cedric Ong <[email protected]> Co-authored-by: Wei Qing <[email protected]>
…AMMATES#12623) * solve the 12607 issue, put mouse hover and add dotted line to the icon * solve the 12607 issue, put mouse hover and add dotted line to the icon * solve the 12607 issue, put mouse hover and add dotted line to the icon --------- Co-authored-by: Wei Qing <[email protected]>
…MATES#12627) * Added unit tests for session-edit-form-component * Added unit tests for session-edit-form-component * added changes to sessioneditformcomponent tests * fixed indent on seesioneditformcomponent tests * moved test in sessioneditformcomponent * made changes to session edit form tests * fixed issues on session edit form component --------- Co-authored-by: Wei Qing <[email protected]>
In the comment edit form, change the button that conditionally displays "Discard" or "Cancel " to only display "Cancel"
Remove redundant newline in Development section of Docs TEAMMATES#12671
…panel chevron barely visible TEAMMATES#12668 (TEAMMATES#12673) * Fix chevron color issue * Replace property binding with static value assignation
…datory field when copying feedback session (TEAMMATES#12670) * Fix Copying feedback session: mark session name as mandatory field when copying feedback session TEAMMATES#12652 * Fix Copying feedback session: mark session name as mandatory field when copying feedback session TEAMMATES#12652 * Fix Copying feedback session: mark session name as mandatory field when copying feedback session TEAMMATES#12652 --------- Co-authored-by: Dominic Lim <[email protected]>
…EAMMATES#12662) * fixed changes & made responsive drop down for the indtructor home page * resolved the issues that are causing test cases that are failing * resolved the Component testing issues that is causing test cases fail. * resolved the E2E testing issues. * resolved the E2E testing issues. * resolved the E2E testing issues. * resolved the E2E testing issues. * resolved the E2E testing issues. * resolved the E2E testing issues. * modified & made small adjustments in the code as required --------- Co-authored-by: Jason Qiu <[email protected]> Co-authored-by: Dominic Lim <[email protected]>
…#12660) * sortBy to CREATION DATE * snapshot update * sort to creation time upon load * linting to specs * trailing space fix * replaces sort with sort function --------- Co-authored-by: Dominic Lim <[email protected]>
…ooltip (TEAMMATES#12675) * Fix grace period tooltip * Update test cases --------- Co-authored-by: Wei Qing <[email protected]> Co-authored-by: Dominic Lim <[email protected]>
…ments (TEAMMATES#12676) * Fix comment tooltip causing the text to go into next line * Update snapshot test --------- Co-authored-by: YX Z <[email protected]> Co-authored-by: Wei Qing <[email protected]> Co-authored-by: Dominic Lim <[email protected]> Co-authored-by: Jason Qiu <[email protected]>
Co-authored-by: Dominic Lim <[email protected]>
…how visibility of the comment as well (TEAMMATES#12659) * Add visibility information for question comments * Fix lint issue * Fix snapshot issues * Standardise text with existing one in response body * Update snapshots --------- Co-authored-by: Wei Qing <[email protected]> Co-authored-by: Jason Qiu <[email protected]> Co-authored-by: Dominic Lim <[email protected]>
…#12696) * implement createSpyFromClass test-helper * update all spys to use new test utility
* Fix duplicate comment button bug in question submission * Update front-end dependencies, Angular to 16 * Update Angular app configurations * Update implementation code * Update test settings + snapshot * Fix new eslint violations * Update stylelint, add prettier to lint for aesthetic-only issues * Make Node.js 18 the minimum requirement * Add BaseAxeTestCase with ability to selectively ignore issues * Make all Axe tests inherit BaseAxeTestCase
* Update some outdated docs * Add new contributors + update old usernames * Update committers and team members list
* create generic builder
…AMMATES#12737) * Update course-edit-form.component.html Removed unnecessary padding * Update course-edit-form.component.spec.ts.snap also added the change in snap file * Revert "Update course-edit-form.component.spec.ts.snap" This reverts commit 897ac22. * Revert "Update course-edit-form.component.html" This reverts commit d74ac3c. * Update instructor-course-edit-page.component.html --------- Co-authored-by: Abdullah-Sohail100 <[email protected]>
* create tests for constsum-recipient-question-constraint * add unit tests for ContributionQuestionConstraintComponent * fix lint issues
This reverts commit b17dda9.
This reverts commit bef05bb.
cedricongjh
force-pushed
the
add-config-for-e2e-sql-tests
branch
from
f410542 to
f4b2e3b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution