Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] SQL injection test for CoursesDbIT #12801

Merged
merged 7 commits into from
Mar 5, 2024
Merged

[#12048] SQL injection test for CoursesDbIT #12801

merged 7 commits into from
Mar 5, 2024

Conversation

weiquu
Copy link
Contributor

@weiquu weiquu commented Feb 25, 2024

Part of #12048

@weiquu weiquu requested a review from EuniceSim142 February 25, 2024 03:55
@weiquu weiquu added the s.ToReview The PR is waiting for review(s) label Feb 25, 2024
@weiquu weiquu added this to the V9.0.0-beta.0 milestone Feb 25, 2024
@weiquu weiquu requested a review from jayasting98 February 25, 2024 04:16
@weiquu weiquu requested a review from jayasting98 February 29, 2024 07:50
jayasting98
jayasting98 approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@jayasting98 jayasting98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be fine now. Thanks!

@jayasting98 jayasting98 added s.FinalReview The PR is ready for final review c.Task Other non-user-facing works, e.g. refactoring, adding tests and removed s.ToReview The PR is waiting for review(s) labels Feb 29, 2024
EuniceSim142
EuniceSim142 approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@EuniceSim142 EuniceSim142 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks 👍

@weiquu weiquu merged commit a8ca0cf into TEAMMATES:master Mar 5, 2024
9 of 11 checks passed
@weiquu weiquu self-assigned this Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EuniceSim142 EuniceSim142 EuniceSim142 approved these changes

@jayasting98 jayasting98 jayasting98 approved these changes

Assignees

@weiquu weiquu

Labels
c.Task Other non-user-facing works, e.g. refactoring, adding tests s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
V9.0.0-beta.0
Development

Successfully merging this pull request may close these issues.
3 participants
@weiquu @jayasting98 @EuniceSim142