Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate netcdf file with check data; delete obsolete files. #64

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Generate netcdf file with check data; delete obsolete files. #64

merged 2 commits into from
Apr 18, 2024

Conversation

efiring
Copy link
Member

@efiring efiring commented Feb 12, 2024

Closes #63.

ocefpaf
ocefpaf approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@ocefpaf ocefpaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efiring LGTM! Are you waiting for some input or more commits? Or should we merge this one?

@efiring efiring merged commit bdf902e into TEOS-10:master Apr 18, 2024
4 checks passed
@efiring efiring deleted the nc_check_values branch April 18, 2024 17:11
@efiring
Copy link
Member Author

efiring commented Apr 18, 2024

Thanks for reviewing and checking.

@ocefpaf
Copy link
Member

ocefpaf commented Apr 18, 2024

Thanks for reviewing and checking.

Sorry it took too long. I also want to finish TEOS-10/GSW-Python#133 to help others contribute to GSW-C/Python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocefpaf ocefpaf ocefpaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update reference values in the NetCDF file?
2 participants
@efiring @ocefpaf