[2주차-1] who...r....u? #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happhee
reviewed
Apr 26, 2022
| @@ -30,3 +31,92 @@ const quizList = [ | |||
| answer: "백지연", | |||
| }, | |||
| ]; | |||
| window.addEventListener('DOMContentLoaded', () => { | |||
Comment on lines
+115
to
+117
| function resetStep() { | ||
| currentStep = 0; | ||
| } |
There was a problem hiding this comment.
함수안에 하나의 코드만 들어가도 모듈화를 시키는 이유는 가독성 때문인가요?!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현 기능 명세
구현사항
ul.answer__list > li에 있는 다섯 가지 이름을 클릭했을 때의 동작을 정의해야해요.imageBoard에 있는 사진의 주인공이 같은 지 비교해요.틀렸습니다!모달을 띄워줘요.scoreBoard__score의 점수를 1점 증가시켜요.imageBoard > image의 이미지 소스를 변경해줘요.다시하기버튼을 누르면 게임을 초기화 시켜주세요.🎁 PR Point
재사용될 수도 있다고 생각해서 최대한 함수를 작게 나눠봤습니다. 그래서 코드가 좀 길어진 것 같아요
😭 어려웠던 점
Commit을 작게 나누려고 했는데 깜빡했어요..
JS로 구현할 때는 동작을 하나씩 다 정의해야해서 힘든 것 같아요,,
😎 구현 결과물