Fix cable race condition

TIOJ-INFOR-Online-Judge · Oct 6, 2023 · 09dc1e5 · 09dc1e5
1 parent e8e7b66
commit 09dc1e5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/TODOLIST.md b/TODOLIST.md
@@ -1,6 +1,7 @@
 - [ ] Modify rejudge behavior
     - Lower priority
     - Separate contest and non-contest submissions
+- [ ] Virtual judge
 - [ ] Batch upload testdata
 - [ ] Revisit all JSON endpoints
 

diff --git a/app/javascript/pages/submissions/main.js b/app/javascript/pages/submissions/main.js
@@ -1,5 +1,5 @@
 import consumer from "../../channels/consumer"
-import { updateSubmissionDetail, updateMultipleSubmissions } from '../../helpers/submission_update'
+import { updateSubmissionDetail, updateMultipleSubmissions } from './submission_update'
 
 export function initSubmissionCable() {
   // id can be integer or array of integers

diff --git a/app/javascript/helpers/submission_update.js → ...pt/pages/submissions/submission_update.js b/app/javascript/helpers/submission_update.js → ...pt/pages/submissions/submission_update.js
@@ -85,7 +85,8 @@ function updateResult(data, cable) {
   if (data['total_time']) $('#total-time').text(data['total_time'])
   if (data['total_memory']) $('#total-memory').text(data['total_memory'])
   if ('score' in data) $('#total-score').text(score_str(data['score']));
-  if (!to_wait) cable.disconnect();
+  // cable message may not always be in order, so delay disconnect to avoid race
+  if (!to_wait) setTimeout(() => cable.disconnect(), 1000);
 }
 
 export function updateSubmissionDetail(data, cable) {