Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial documentation for the AsciiDoc reporter #1353

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johthor
Copy link
Contributor

@johthor johthor commented Jul 24, 2023

Describe how the AsciiDoc report may be generated via CLI or Maven.

Unfortunately I couldn't describe the Gradle configuration.

The sections for the Maven and Gradle Plugin will be upgraded to level 2 because it didn't make sense to describe them twice. Once for HTML and once for Asciidoc.

Issue: #54

l-1squared
l-1squared previously approved these changes Jul 25, 2023
Copy link
Collaborator

@l-1squared l-1squared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for cleaning up this file

@l-1squared
Copy link
Collaborator

l-1squared commented Sep 8, 2023

⚠️ @johthor can this be merged?
I'd like to do a release (we have a bug open that was already fixed on master) and frankly we should have done one already. But I don't want to cut out your contribution from the release (would make a real mess of the commit graph). Rather I think it makes more sense to add this docs with a mark "Experimental"

@johthor johthor force-pushed the 54-asciiDocReporter-documentation branch from 23f8135 to 1a9685d Compare December 28, 2023 19:03
@l-1squared
Copy link
Collaborator

Hi @johthor
I do know that life can easily get in the way of open source contributions. I want to ask, whether you still have this project on the radar. It would be a pity if your significant contribution remained incomplete. It also pains me that I feel I cannot honor your efforts in the Changelog, because that would mean officialy releasing the feature, which I can't because it is incomplete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants