Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1040: Preferences window - date overflowing icon after electron … #1041

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

araujoarthur0
Copy link
Collaborator

@araujoarthur0 araujoarthur0 commented Nov 20, 2023

Closes #1040

Before:
image

After:
image

Seems electron removed the overflow that was fixed with the left configuration.

Copy link

codecov bot commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (26066c4) 79.37% compared to head (a788225) 79.37%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1041   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files          21       21           
  Lines        1275     1275           
  Branches      189      189           
=======================================
  Hits         1012     1012           
  Misses        263      263           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@tupaschoal tupaschoal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tested and works fine, one hack less, thanks!

@tupaschoal tupaschoal merged commit 8c4e573 into TTLApp:main Nov 21, 2023
8 checks passed
@tupaschoal
Copy link
Collaborator

\changelog-update
Message: Fix [#1040]: Date overlapping icon on preference window after electron 27.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Preferences window - date overflowing icon
2 participants