Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop exposing defaultPreferences variable #1109

Merged
merged 2 commits into from
Jan 5, 2025
Merged

Stop exposing defaultPreferences variable #1109

merged 2 commits into from
Jan 5, 2025

Conversation

tupaschoal
Copy link
Collaborator

As requested on #1055 (comment)

@netlify Netlify
Copy link

netlify bot commented Jan 5, 2025 •
edited
Loading

✅ Deploy Preview for time-to-leave canceled.

Name Link
🔨 Latest commit c3bba5d
🔍 Latest deploy log https://app.netlify.com/sites/time-to-leave/deploys/677a8f1f64d689000847c0a3

@tupaschoal
Copy link
Collaborator Author

Had to use structuredClone because for some reason the test seemed to be reusing the defaultPreferences from a previous it

@araujoarthur0 araujoarthur0 merged commit b150f50 into TTLApp:main Jan 5, 2025
7 checks passed
@tupaschoal tupaschoal deleted the defaul-prefs branch January 5, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thamara thamara thamara approved these changes

@araujoarthur0 araujoarthur0 araujoarthur0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tupaschoal @thamara @araujoarthur0