Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use electronmon for debug:main debug:render and start #1149

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

Atomic-Germ
Copy link
Contributor

@Atomic-Germ Atomic-Germ commented Feb 8, 2025

Context / Background

Replaces debugger with electronmon

What change is being introduced by this PR?

  • I looked at alternate methods and found electronmon to be what I consider the best one
  • Basically just added “mon” to the debug commands.
  • Better debugging with faster reloading and more, clearer information.
Screenshot 2025-02-08 at 9 07 13 AM

@Atomic-Germ Atomic-Germ marked this pull request as draft February 8, 2025 17:20
@Atomic-Germ
Copy link
Contributor Author

Atomic-Germ commented Feb 8, 2025

Currently, something is causing rifraf to fail out with a command not found. Trying to figure out why.

Screenshot 2025-02-08 at 9 20 27 AM

EDIT: Fixed by not forcing the resolution of rimraf.

Copy link

codecov bot commented Feb 8, 2025

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment

Thanks for integrating Codecov - We've got you covered ☂️

@Atomic-Germ Atomic-Germ force-pushed the debug-add-electronmon branch from b76efa4 to 7827096 Compare February 8, 2025 18:40
@Atomic-Germ Atomic-Germ marked this pull request as ready for review February 8, 2025 18:49
@araujoarthur0
Copy link
Collaborator

Like @tupaschoal mentioned in the other PR, we could add this to npm start directly as well. We don't often use the debug targets.
Also, please remove the electron reloader references since this replaces it.

@araujoarthur0
Copy link
Collaborator

araujoarthur0 commented Feb 8, 2025

Consider adding an exception to test files as well like the docs suggest.
https://github.com/catdad/electronmon?tab=readme-ov-file#configuration

@Atomic-Germ
Copy link
Contributor Author

@araujoarthur0 Done, done, and done.

@Atomic-Germ Atomic-Germ force-pushed the debug-add-electronmon branch from ac4b8d6 to aa7b588 Compare February 9, 2025 16:13
@tupaschoal tupaschoal merged commit 7b05d4f into TTLApp:main Feb 10, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants