Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Unify confvals for config section #1162

Merged
merged 3 commits into from
Mar 26, 2024
Merged

[TASK] Unify confvals for config section #1162

merged 3 commits into from
Mar 26, 2024

Conversation

linawolf
Copy link
Member

Replace aspect table with confval where not yet happened.

Use unified names

We should have a look at the default values in a follow up. Some are missing, some are integers for type boolean.

Releases: main, 12.4

Replace aspect table with confval where not yet happened.

Use unified names

We should have a look at the default values in a follow up. Some
are missing, some are integers for type boolean.

Releases: main, 12.4
@linawolf linawolf requested a review from brotkrueml March 26, 2024 11:45
@linawolf linawolf self-assigned this Mar 26, 2024
@garvinhicking
Copy link
Contributor

Phew, this is hard to review, I could offer a vote of confidence only 😜

Documentation/Setup/Config/Index.rst Outdated Show resolved Hide resolved
Documentation/Setup/Config/Index.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@brotkrueml brotkrueml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed it and it is fine for me, although haven't tested it. So, go ahead.

@linawolf linawolf merged commit a089ded into main Mar 26, 2024
2 checks passed
@linawolf linawolf deleted the task/confvals branch March 26, 2024 13:24
linawolf added a commit that referenced this pull request May 20, 2024
* [TASK] Unify confvals for config section

Replace aspect table with confval where not yet happened.

Use unified names

We should have a look at the default values in a follow up. Some
are missing, some are integers for type boolean.

Releases: main, 12.4

* Update Documentation/Setup/Config/Index.rst

Co-authored-by: Chris Müller <[email protected]>

* [TASK] Indent TypoScript

---------

Co-authored-by: Chris Müller <[email protected]>

(cherry picked from commit a089ded)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants