Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Use custom types for linking object properties in GIFBUILDER chapter #900

Merged

Conversation

brotkrueml
Copy link
Contributor

Releases: main, 12.4, 11.5

Copy link
Member

@linawolf linawolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So would you like to continue to replace all the former simple references with custom once? I thought we wanted to put custom anchors and link them?

@brotkrueml
Copy link
Contributor Author

So would you like to continue to replace all the former simple references with custom once? I thought we wanted to put custom anchors and link them?

I don't know yet, but as you started with them last year and I started also with the GIFBUILDER without thinking really about it, well ...

@brotkrueml
Copy link
Contributor Author

And you've got a valid point, a separate type has better semantics than using a confval directive.

@brotkrueml brotkrueml requested a review from linawolf November 13, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants