Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events upgrade #200

Merged
merged 13 commits into from
Nov 25, 2023
Merged

Events upgrade #200

merged 13 commits into from
Nov 25, 2023

Conversation

quent043
Copy link
Contributor

New PR:

Useful info

  • Trello:
  • Description:

Auto-Review checklist

  • Check if there is no merge conflict
  • If you have new .env variable, check if you add it in the .env.example file

Typing

  • Check lint feedbacks: npm run lint
  • Check prettier format feedbacks: npm run format

quent043 and others added 8 commits October 17, 2023 09:22
@quent043 quent043 requested a review from 0xRomain October 19, 2023 11:06
@quent043
Renamed archive contract
c442be5 
Signed-off-by: Quentin D.C <[email protected]>
@quent043
Removed unused import
ad2e4f8 
Signed-off-by: Quentin D.C <[email protected]>
@quent043
Updated RPC
b4fdc63 
Signed-off-by: Quentin D.C <[email protected]>
@quent043
Added event Payment emit in tests
10dc721 
Signed-off-by: Quentin D.C <[email protected]>
@quent043
Fixed test error
80b1f8a 
Signed-off-by: Quentin D.C <[email protected]>
@quent043 quent043 added the NEED REVIEW Dev is waiting for peer review label Nov 24, 2023
@0xRomain 0xRomain merged commit dd56c83 into main Nov 25, 2023
1 check passed
@0xRomain 0xRomain deleted the events_upgrade branch November 25, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xRomain 0xRomain Awaiting requested review from 0xRomain

Assignees
No one assigned
Labels
NEED REVIEW Dev is waiting for peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quent043 @0xRomain @yashgo0018