Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

383 uncompleted service #201

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

383 uncompleted service #201

wants to merge 2 commits into from

Conversation

quent043
Copy link
Contributor

New PR:

Useful info

  • Trello: https://trello.com/c/Z6vN29gQ/383-graph-issue-uncompleted-service
  • Description: The current PaymentComplete event does not hold enough data to know whether a service in Finished or Uncompleted. We needed to add an event param in the PaymentCompleted event as somehow the Graph does not allow to do nested queries and we needed Transaction infos update the service status.

Auto-Review checklist

  • Check if there is no merge conflict
  • If you have new .env variable, check if you add it in the .env.example file

Typing

  • Check lint feedbacks: npm run lint
  • Check prettier format feedbacks: npm run format

@quent043
Added event in contract
5fcb8d4 
Updated tests
@quent043
Fixed mistakes in Transaction Ids
45ad660 
Modified rates to get Uncompleted service
@quent043 quent043 added the NEED REVIEW Dev is waiting for peer review label Nov 28, 2023
@quent043 quent043 requested a review from 0xRomain November 28, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xRomain 0xRomain Awaiting requested review from 0xRomain

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
NEED REVIEW Dev is waiting for peer review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@quent043