-
-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose SolidFormApi
type
#892
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 1a5e486. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
Thanks for the PR! Can you also export the type from On a separate note, we're drafting a recommended approach for building custom/wrapper components in React, but I'd say the needs and challenges are the same for all frameworks. Since you're also doing something similar, if you have feedback please share them in #825 |
Whoops, can't believe I forgot it in the Great to see your looking into this area. The example you linked looks one to one with what i've got (minus the React/Solid differences). It's worth mentioning another motivation for this PR is when you run into a Typescript error like:
I am ran into this error when returning a Being able to refer to |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #892 +/- ##
==========================================
+ Coverage 91.55% 91.66% +0.11%
==========================================
Files 21 2 -19
Lines 900 36 -864
Branches 206 1 -205
==========================================
- Hits 824 33 -791
+ Misses 71 3 -68
+ Partials 5 0 -5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
I'm currently building a
InputField
abstraction wrapping a form and it would be useful to be able to directly name the type.For now i'm doing the following but it's kinda annoying: