-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(react-query): add support for react19 in v4 #8441
base: v4
Are you sure you want to change the base?
Conversation
View your CI Pipeline Execution ↗ for commit 2c1cc86.
☁️ Nx Cloud last updated this comment at |
@gwansikk Cool! PeerDep of other packages depending on react should be updated! |
Using v4 and would love this addition |
The task was delayed due to a busy schedule, but it will be completed soon. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2c1cc86:
|
I’ve been working on making react-query compatible with React 19 but encountered a few issues:
I’ve tested compatibility with React 19 using |
"pnpm": { | ||
"overrides": { | ||
"react": "18.2.0", | ||
"react-dom": "18.2.0", | ||
"@types/react": "^18.0.14", | ||
"@types/react-dom": "^18.0.5" | ||
} | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To test React 17 and 18, I had to use overrides
.
Currently, react-query
executes the test environment for each React version through PR-CI. However, since the version of @testing-library/react
is fixed at React 19, errors occur due to breaking changes related to JSX and React.act
.
'@testing-library/react-17':
specifier: npm:@testing-library/[email protected]
version: /@testing-library/[email protected]([email protected])([email protected]) # <<-- Fixed: React19
'@testing-library/react-18':
specifier: npm:@testing-library/[email protected]
version: /@testing-library/[email protected]([email protected])([email protected]) # <<-- Fixed: React19
Hello! I am the maintainer of the Suspensive (react-query community project)
With the release of React 19 Stable, we are working to make Suspensive compatible with React 19 as well. However, we are encountering an issue because react-query v4 does not yet support React 19. To address this, I propose that react-query v4 should also include React 19 in its package dependencies.