43 constant pool vm #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levBagryansky
force-pushed
the
43_constant_pool_vm
branch
from
f2a53a1 to
45bbc57
Compare
c71n93
requested changes
Oct 29, 2023
c71n93
requested changes
Oct 29, 2023
| throw std::invalid_argument(std::string{"Bad input stream"}); | ||
| } | ||
| uint16_t constants = 0; | ||
| static_assert(sizeof constants == 2); |
There was a problem hiding this comment.
remove it, please. it is better to check sizeof(constant) == sizeof(Immediate) but when you make constant of type Immediate it will be unnecessary.
There was a problem hiding this comment.
@c71n93 let's leave it. What if once we decide write number of constants to file in 4 bytes instead of 2, but immediate will still be 2 bytes. I leave this assert just for safety
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Constant pool for i64 and f64