#92 changed variant editor to use new package.manifest format, #91 added null check on attribute group #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & now persists to dataNtext in cmsPropertyData.
jamiehowarth0
changed the title
|
@benjaminhowarth1 have you checked what happens as part of an upgrade? does the data get moved over? or do we still need to implement that? Also, can you re-target your PR to be against the dev branch? Really nice work fella 👍 |
|
Data migration will need writing, I haven't had a chance to address that yet. |
|
Proof of concept to migrate data from nvarchar to ntext in cmsPropertyData: https://gist.github.com/benjaminhowarth1/2e94c7cb0747cd9854cbb0987322d5f6 |
|
@benjaminhowarth1 looks good to me. Some awesome work here fella 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested & now persists to dataNtext in cmsPropertyData.