Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

매칭 페이지 버그 수정 #125

Merged
merged 34 commits into from
Jun 1, 2024
Merged

매칭 페이지 버그 수정 #125

merged 34 commits into from
Jun 1, 2024

Conversation

seheon99
Copy link
Contributor

@seheon99 seheon99 commented May 29, 2024 •
edited
Loading

변경 개요

구현 내용

  • 내 정보 확인에서 학력/경력 enum 에서 문자로 변환하기
  • 내 정보 확인에서 포트폴리오 나오게 하기
  • 매칭 중일 때 나오는 dummyData 이미지를 positionImage 로 수정하기
  • 매칭 중 완료가 되었는지 주기적으로 확인하기
  • 매칭방 나가기 했을 경우 다시 맨 처음으로 돌아가게 하기

관련 이슈

@seheon99 seheon99 self-assigned this May 29, 2024
@vercel Vercel
Copy link

vercel bot commented May 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fit-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2024 7:29pm

seheon99 added 16 commits May 31, 2024 04:22
@seheon99
feature: Add notice message type
8fa12eb
@seheon99
feat: Add NoticeBubble component for displaying notice messages
f91afc7
@seheon99
feature: Add NoticeBubble component for displaying notice messages
1d5e7fa
@seheon99
refactor: Remove unnecessary unshift messaging logic
27b7361
@seheon99
refactor: Remove unnecessary dependency
d6a6070
@seheon99
fix: Remove debugging code
f71bb45
@seheon99
feature: Add image message handler
6ac55cb
@seheon99
fix: Check all policies
78078dd
@seheon99
fix: Only one policy can be expanded
f1c04dc
@seheon99
fix: Add gap between policy box entities
49df685
@seheon99
fix: Change the height of policy content box
df4d478
@seheon99
fix: Toggle all policies
828ae27
@seheon99
fix: Remove key error in NestedList
ca8b204
@seheon99
fix: Change color and size of close button
1ca05d4
@seheon99
refactor: Move UserDetailModal to common UserModal component
c380284
@seheon99
refactor: Extract modal feature of UserDetails to UserDetailsModal
06c3f2a
@seheon99 seheon99 marked this pull request as ready for review May 30, 2024 19:24
@seheon99
Copy link
Contributor Author

seheon99 commented May 30, 2024 •
edited
Loading

@jaewoongs 브랜치를 dev 에서 잘못 가져와서 작업해가지구 커밋이 전부 rebase 된 것 같은데... 다른 풀리퀘보다 먼저 머지해야될 것 같아요! 딴거 먼저 머지하면 이거 머지될 때 덮어쓰기될듯

@seheon99 seheon99 linked an issue May 30, 2024 that may be closed by this pull request
랜덤 팀 매칭 수정사항 #117
Closed
5 tasks
@jaewoongs jaewoongs merged commit 71ca35c into dev Jun 1, 2024
6 checks passed
@jaewoongs jaewoongs deleted the fix/117-matching-bugs branch June 1, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaewoongs jaewoongs jaewoongs approved these changes

Assignees

@seheon99 seheon99

Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

랜덤 팀 매칭 수정사항
2 participants
@seheon99 @jaewoongs