Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed using the wrench to break legacy machine blocks not working. #1000

Open
wants to merge 1 commit into
base: dev/1.21.1
Choose a base branch
from

Conversation

CrazyPants
Copy link
Contributor

Description

Breaking any legacy machine blocks with a wrench threw exceptions. This was caused by a side only annotation on a method that checked for server side specific code.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@dphaldes
Copy link
Contributor

dphaldes commented Feb 13, 2025

This PR makes sense but I wonder why was it added in the first place.
@ferriarnus why was this annotation added in 144dd4e ?

@ferriarnus
Copy link
Member

This PR makes sense but I wonder why was it added in the first place. @ferriarnus why was this annotation added in 144dd4e ?

no idea anymore

@dphaldes
Copy link
Contributor

Could it be that it was commented out orginally before Ensure was ported over and you made a mistake when reenabling it? (Server -> Client) ?

@dphaldes dphaldes self-assigned this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants